beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 09:00:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

CI+Meta: Delete wasm workflow and js_repl module

Browse source
This commit is contained in:
Andrew Kaster 2024-06-21 18:38:31 -06:00 committed by Tim Flynn
parent 4ea2ff82ac
commit 79db3b32c2
Notes: sideshowbarker 2024-07-16 20:05:14 +09:00 
Author: https://github.com/ADKaster
Commit: https://github.com/LadybirdBrowser/ladybird/commit/79db3b32c2
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/202
Reviewed-by: https://github.com/trflynn89 ✅
3 changed files with 0 additions and 465 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

111
.github/workflows/wasm.yml vendored
View file

@ -1,111 +0,0 @@
name: Build Wasm Modules
on: [ push, pull_request ]
env:
LADYBIRD_SOURCE_DIR: ${{ github.workspace }}
SERENITY_CCACHE_DIR: ${{ github.workspace }}/.ccache
concurrency: wasm
jobs:
build:
runs-on: ubuntu-22.04
if: false
strategy:
fail-fast: false
steps:
- name: Checkout LadybirdBrowser/ladybird
uses: actions/checkout@v4
- name: Checkout SerenityOS/libjs-data libjs-wasm
uses: actions/checkout@v4
with:
repository: SerenityOS/libjs-data
path: libjs-data
ref: libjs-wasm
- name: "Set up environment"
uses: ./.github/actions/setup
with:
os: 'Linux'
arch: 'Lagom'
- name: "Install emscripten"
uses: mymindstorm/setup-emsdk@v14
with:
version: 3.1.25
- name: Restore Caches
uses: ./.github/actions/cache-restore
id: 'cache-restore'
with:
os: 'Linux'
arch: 'Lagom'
cache_key_extra: 'WASM'
serenity_ccache_path: ${{ env.SERENITY_CCACHE_DIR }}
download_cache_path: ${{ github.workspace }}/Build/caches
- name: "Build host lagom tools"
run: |
cmake -GNinja \
-B ${{ github.workspace }}/Build/lagom-tools \
-S ${{ github.workspace }}/Meta/Lagom \
-DLAGOM_TOOLS_ONLY=ON
-DSERENITY_CACHE_DIR=${{ github.workspace }}/Build/caches \
-DCMAKE_C_COMPILER=gcc-13 \
-DCMAKE_CXX_COMPILER=g++-13 \
-DCMAKE_INSTALL_PREFIX=${{ github.workspace }}/Build/lagom-tools \
-Dpackage=LagomTools
ninja -C ${{ github.workspace }}/Build/lagom-tools install
env:
CCACHE_DIR: ${{ env.SERENITY_CCACHE_DIR }}
- name: "Create wasm build environment"
run: |
emcmake cmake -GNinja \
-B ${{ github.workspace }}/Build/wasm \
-S ${{ github.workspace }}/Meta/Lagom \
-DLagomTools_DIR=${{ github.workspace }}/Build/lagom-tools/share/LagomTools \
-DSERENITY_CACHE_DIR=${{ github.workspace }}/Build/caches \
-DBUILD_SHARED_LIBS=OFF
env:
CCACHE_DIR: ${{ env.SERENITY_CCACHE_DIR }}
- name: "Build libjs.{js,wasm}"
run: |
ninja -C ${{ github.workspace }}/Build/wasm libjs.js
env:
CCACHE_DIR: ${{ env.SERENITY_CCACHE_DIR }}
- name: Save Caches
uses: ./.github/actions/cache-save
with:
arch: 'Lagom'
serenity_ccache_path: ${{ env.SERENITY_CCACHE_DIR }}
serenity_ccache_primary_key: ${{ steps.cache-restore.outputs.serenity_ccache_primary_key }}
- name: "Prepare files"
run: |
cp ${{ github.workspace }}/Build/wasm/bin/libjs.js ${{ github.workspace }}/libjs-data/libjs.js
cp ${{ github.workspace }}/Build/wasm/bin/libjs.wasm ${{ github.workspace }}/libjs-data/libjs.wasm
echo 'Module.SERENITYOS_COMMIT = "${{ github.sha }}";' >> ${{ github.workspace }}/libjs-data/libjs.js
tar --exclude='.[^/]*' -czvf libjs-wasm.tar.gz -C ${{ github.workspace }}/libjs-data .
- name: Deploy to GitHub
uses: JamesIves/github-pages-deploy-action@v4.6.1
if: github.ref == 'refs/heads/master'
with:
git-config-name: BuggieBot
git-config-email: buggiebot@serenityos.org
branch: libjs-wasm
repository-name: SerenityOS/libjs-data
token: ${{ secrets.BUGGIEBOT_TOKEN }}
folder: ${{ github.workspace }}/libjs-data
- name: Upload artifact package
if: github.ref == 'refs/heads/master'
uses: actions/upload-artifact@v4
with:
name: serenity-js-wasm
path: libjs-wasm.tar.gz
retention-days: 7

9
Meta/Lagom/CMakeLists.txt
View file

@ -460,15 +460,6 @@ lagom_utility(image SOURCES ../../Userland/Utilities/image.cpp LIBS LibGfx LibMa
lagom_utility(ttfdisasm SOURCES ../../Userland/Utilities/ttfdisasm.cpp LIBS LibGfx LibMain)
lagom_utility(js SOURCES ../../Userland/Utilities/js.cpp LIBS LibCrypto LibJS LibLine LibLocale LibMain LibTextCodec Threads::Threads)
if (EMSCRIPTEN)
lagom_utility(libjs SOURCES Wasm/js_repl.cpp LIBS LibJS LibLocale LibTimeZone LibUnicode)
target_link_options(libjs PRIVATE
-sEXPORTED_FUNCTIONS=_initialize_repl,_execute
-sEXPORTED_RUNTIME_METHODS=allocateUTF8
-sERROR_ON_UNDEFINED_SYMBOLS=0
-sENVIRONMENT=web)
endif()
lagom_utility(lzcat SOURCES ../../Userland/Utilities/lzcat.cpp LIBS LibCompress LibMain)
lagom_utility(tar SOURCES ../../Userland/Utilities/tar.cpp LIBS LibArchive LibCompress LibFileSystem LibMain)

345
Meta/Lagom/Wasm/js_repl.cpp
View file

@ -1,345 +0,0 @@
/*
* Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2020-2023, Linus Groh <linusg@serenityos.org>
* Copyright (c) 2020-2022, Ali Mohammad Pur <mpfard@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibCore/ArgsParser.h>
#include <LibCore/ConfigFile.h>
#include <LibCore/StandardPaths.h>
#include <LibCore/System.h>
#include <LibJS/AST.h>
#include <LibJS/Bytecode/BasicBlock.h>
#include <LibJS/Bytecode/Generator.h>
#include <LibJS/Bytecode/Interpreter.h>
#include <LibJS/Console.h>
#include <LibJS/Parser.h>
#include <LibJS/Print.h>
#include <LibJS/Runtime/ConsoleObject.h>
#include <LibJS/Runtime/GlobalObject.h>
#include <LibJS/Runtime/JSONObject.h>
#include <LibJS/Runtime/StringPrototype.h>
#include <LibJS/SourceTextModule.h>
#include <LibLine/Editor.h>
#include <LibMain/Main.h>
#include <LibTextCodec/Decoder.h>
#include <fcntl.h>
#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#ifndef AK_OS_EMSCRIPTEN
# error "This program is for Emscripten only"
#endif
#include <emscripten.h>
class ReplConsoleClient;
RefPtr<JS::VM> g_vm;
OwnPtr<JS::ExecutionContext> g_execution_context;
OwnPtr<ReplConsoleClient> g_console_client;
JS::Handle<JS::Value> g_last_value = JS::make_handle(JS::js_undefined());
EM_JS(void, user_display, (char const* string, u32 length), { globalDisplayToUser(UTF8ToString(string, length)); });
template<typename... Args>
void display(CheckedFormatString<Args...> format_string, Args const&... args)
{
auto string = ByteString::formatted(format_string.view(), args...);
user_display(string.characters(), string.length());
}
template<typename... Args>
void displayln(CheckedFormatString<Args...> format_string, Args const&... args)
{
display(format_string.view(), args...);
user_display("\n", 1);
}
void displayln() { user_display("\n", 1); }
class UserDisplayStream final : public Stream {
virtual ErrorOr<Bytes> read_some(Bytes) override { return Error::from_string_view("Not readable"sv); }
virtual ErrorOr<size_t> write_some(ReadonlyBytes bytes) override
{
user_display(bit_cast<char const*>(bytes.data()), bytes.size());
return bytes.size();
}
virtual bool is_eof() const override { return true; }
virtual bool is_open() const override { return true; }
virtual void close() override { }
};
ErrorOr<void> print(JS::Value value)
{
UserDisplayStream stream;
JS::PrintContext print_context {
.vm = *g_vm,
.stream = stream,
.strip_ansi = true,
};
return JS::print(value, print_context);
}
class ReplObject final : public JS::GlobalObject {
JS_OBJECT(ReplObject, JS::GlobalObject);
public:
ReplObject(JS::Realm& realm)
: GlobalObject(realm)
{
}
virtual void initialize(JS::Realm&) override;
virtual ~ReplObject() override = default;
private:
JS_DECLARE_NATIVE_FUNCTION(last_value_getter);
JS_DECLARE_NATIVE_FUNCTION(print);
};
static bool s_dump_ast = false;
static bool s_as_module = false;
static bool s_print_last_result = false;
static ErrorOr<bool> parse_and_run(JS::Realm& realm, StringView source, StringView source_name)
{
auto& interpreter = g_vm->bytecode_interpreter();
enum class ReturnEarly {
No,
Yes,
};
JS::ThrowCompletionOr<JS::Value> result { JS::js_undefined() };
auto run_script_or_module = [&](auto& script_or_module) -> ErrorOr<ReturnEarly> {
if (s_dump_ast)
script_or_module->parse_node().dump(0);
result = interpreter.run(*script_or_module);
return ReturnEarly::No;
};
if (!s_as_module) {
auto script_or_error = JS::Script::parse(source, realm, source_name);
if (script_or_error.is_error()) {
auto error = script_or_error.error()[0];
auto hint = error.source_location_hint(source);
if (!hint.is_empty())
displayln("{}", hint);
auto error_string = error.to_string();
displayln("{}", error_string);
result = g_vm->throw_completion<JS::SyntaxError>(move(error_string));
} else {
auto return_early = TRY(run_script_or_module(script_or_error.value()));
if (return_early == ReturnEarly::Yes)
return true;
}
} else {
auto module_or_error = JS::SourceTextModule::parse(source, realm, source_name);
if (module_or_error.is_error()) {
auto error = module_or_error.error()[0];
auto hint = error.source_location_hint(source);
if (!hint.is_empty())
displayln("{}", hint);
auto error_string = error.to_string();
displayln("{}", error_string);
result = g_vm->throw_completion<JS::SyntaxError>(move(error_string));
} else {
auto return_early = TRY(run_script_or_module(module_or_error.value()));
if (return_early == ReturnEarly::Yes)
return true;
}
}
auto handle_exception = [&](JS::Value thrown_value) {
display("Uncaught exception: ");
(void)print(thrown_value);
if (!thrown_value.is_object() || !is<JS::Error>(thrown_value.as_object()))
return;
displayln("{}", static_cast<JS::Error const&>(thrown_value.as_object()).stack_string(JS::CompactTraceback::Yes));
};
if (!result.is_error())
g_last_value = JS::make_handle(result.value());
if (result.is_error()) {
VERIFY(result.throw_completion().value().has_value());
handle_exception(*result.release_error().value());
return false;
}
if (s_print_last_result) {
(void)print(result.value());
display("\n");
}
return true;
}
void ReplObject::initialize(JS::Realm& realm)
{
Base::initialize(realm);
define_direct_property("global", this, JS::Attribute::Enumerable);
u8 attr = JS::Attribute::Configurable | JS::Attribute::Writable | JS::Attribute::Enumerable;
define_native_function(realm, "print", print, 1, attr);
define_native_accessor(
realm,
"_",
[](JS::VM&) {
return g_last_value.value();
},
[](JS::VM& vm) -> JS::ThrowCompletionOr<JS::Value> {
auto& global_object = vm.get_global_object();
VERIFY(is<ReplObject>(global_object));
displayln("Disable writing last value to '_'");
// We must delete first otherwise this setter gets called recursively.
TRY(global_object.internal_delete(JS::PropertyKey { "_" }));
auto value = vm.argument(0);
TRY(global_object.internal_set(JS::PropertyKey { "_" }, value, &global_object));
return value;
},
attr);
}
JS_DEFINE_NATIVE_FUNCTION(ReplObject::print)
{
auto result = ::print(vm.argument(0));
if (result.is_error())
return g_vm->throw_completion<JS::InternalError>(TRY_OR_THROW_OOM(*g_vm, String::formatted("Failed to print value: {}", result.error())));
displayln();
return JS::js_undefined();
}
class ReplConsoleClient final : public JS::ConsoleClient {
public:
ReplConsoleClient(JS::Console& console)
: ConsoleClient(console)
{
}
virtual void clear() override
{
display("FIXME: clear");
m_group_stack_depth = 0;
}
virtual void end_group() override
{
if (m_group_stack_depth > 0)
m_group_stack_depth--;
}
// 2.3. Printer(logLevel, args[, options]), https://console.spec.whatwg.org/#printer
virtual JS::ThrowCompletionOr<JS::Value> printer(JS::Console::LogLevel log_level, PrinterArguments arguments) override
{
ByteString indent = ByteString::repeated(" "sv, m_group_stack_depth);
if (log_level == JS::Console::LogLevel::Trace) {
auto trace = arguments.get<JS::Console::Trace>();
StringBuilder builder;
if (!trace.label.is_empty())
builder.appendff("{}{}\n", indent, trace.label);
for (auto& function_name : trace.stack)
builder.appendff("{}-> {}\n", indent, function_name);
displayln("{}", builder.string_view());
return JS::js_undefined();
}
if (log_level == JS::Console::LogLevel::Group || log_level == JS::Console::LogLevel::GroupCollapsed) {
auto group = arguments.get<JS::Console::Group>();
displayln("{}{}", indent, group.label);
m_group_stack_depth++;
return JS::js_undefined();
}
auto output = ByteString::join(' ', arguments.get<JS::MarkedVector<JS::Value>>());
switch (log_level) {
case JS::Console::LogLevel::Debug:
displayln("{}{}", indent, output);
break;
case JS::Console::LogLevel::Error:
case JS::Console::LogLevel::Assert:
displayln("{}{}", indent, output);
break;
case JS::Console::LogLevel::Info:
displayln("{}(i) {}", indent, output);
break;
case JS::Console::LogLevel::Log:
displayln("{}{}", indent, output);
break;
case JS::Console::LogLevel::Warn:
case JS::Console::LogLevel::CountReset:
displayln("{}{}", indent, output);
break;
default:
displayln("{}{}", indent, output);
break;
}
return JS::js_undefined();
}
private:
int m_group_stack_depth { 0 };
};
extern "C" int initialize_repl(char const* time_zone)
{
if (time_zone)
setenv("TZ", time_zone, 1);
g_vm = MUST(JS::VM::create());
g_vm->set_dynamic_imports_allowed(true);
// NOTE: These will print out both warnings when using something like Promise.reject().catch(...) -
// which is, as far as I can tell, correct - a promise is created, rejected without handler, and a
// handler then attached to it. The Node.js REPL doesn't warn in this case, so it's something we
// might want to revisit at a later point and disable warnings for promises created this way.
g_vm->on_promise_unhandled_rejection = [](auto& promise) {
display("WARNING: A promise was rejected without any handlers");
display(" (result: ");
(void)print(promise.result());
displayln(")");
};
g_vm->on_promise_rejection_handled = [](auto& promise) {
display("WARNING: A handler was added to an already rejected promise");
display(" (result: ");
(void)print(promise.result());
displayln(")");
};
s_print_last_result = true;
g_execution_context = JS::create_simple_execution_context<ReplObject>(*g_vm);
auto& realm = *g_execution_context->realm;
auto console_object = realm.intrinsics().console_object();
g_console_client = make<ReplConsoleClient>(console_object->console());
console_object->console().set_client(*g_console_client);
return 0;
}
extern "C" bool execute(char const* source)
{
if (auto result = parse_and_run(*g_execution_context->realm, { source, strlen(source) }, "REPL"sv); result.is_error()) {
displayln("{}", result.error());
return false;
} else {
return result.value();
}
}