beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Kernel: Fix Clang not initializing s_bsp_processor correctly

Browse source 
Initializing the variable this way fixes a kernel panic in Clang where
the object was zero-initialized, so the `m_in_scheduler` contained the
wrong value. GCC got it right, but we're better off making this change,
as leaving uninitialized fields in constant-initialized objects can
cause other weird situations like this. Also, initializing only a single
field to a non-zero value isn't worth the cost of no longer fitting in
`.bss`.

Another two variables suffer from the same problem, even though their
values are supposed to be zero. Removing these causes the
`_GLOBAL_sub_I_` function to no longer be generated and the (not
handled) `.init_array` section to be omitted.
This commit is contained in:
Daniel Bertalan 2021-08-29 19:31:22 +02:00 committed by Andreas Kling
parent f0b3aa0331
commit 779cf49f38
Notes: sideshowbarker 2024-07-18 05:05:38 +09:00 
Author: https://github.com/BertalanD
Commit: https://github.com/SerenityOS/serenity/commit/779cf49f38e
Pull-request: https://github.com/SerenityOS/serenity/pull/9678
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Kernel/Arch/x86/Processor.h
View file

@ -119,8 +119,8 @@ class Processor {
u32 m_gdt_length; u32 m_gdt_length;
u32 m_cpu; u32 m_cpu;
FlatPtr m_in_irq {}; FlatPtr m_in_irq;
volatile u32 m_in_critical {}; volatile u32 m_in_critical;
static Atomic<u32> s_idle_cpu_mask; static Atomic<u32> s_idle_cpu_mask;
TSS m_tss; TSS m_tss;
@ -137,7 +137,7 @@ class Processor {
bool m_invoke_scheduler_async; bool m_invoke_scheduler_async;
bool m_scheduler_initialized; bool m_scheduler_initialized;
bool m_in_scheduler { true }; bool m_in_scheduler;
Atomic<bool> m_halt_requested; Atomic<bool> m_halt_requested;
DeferredCallEntry* m_pending_deferred_calls; // in reverse order DeferredCallEntry* m_pending_deferred_calls; // in reverse order

1
Kernel/Arch/x86/common/Processor.cpp
View file

@ -305,6 +305,7 @@ UNMAP_AFTER_INIT void Processor::early_initialize(u32 cpu)
m_invoke_scheduler_async = false; m_invoke_scheduler_async = false;
m_scheduler_initialized = false; m_scheduler_initialized = false;
m_in_scheduler = true;
m_message_queue = nullptr; m_message_queue = nullptr;
m_idle_thread = nullptr; m_idle_thread = nullptr;