beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-29 19:10:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibJS: Convert WeakRef.prototype to be a PrototypeObject

Browse source
This commit is contained in:
Timothy Flynn 2021-09-11 15:54:18 -04:00 committed by Andreas Kling
parent 966f4faae4
commit 777ae53615
Notes: sideshowbarker 2024-07-18 04:13:23 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/777ae53615e
Pull-request: https://github.com/SerenityOS/serenity/pull/9973
Reviewed-by: https://github.com/linusg ✅
2 changed files with 9 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibJS/Runtime/WeakRefPrototype.cpp
View file

@ -10,7 +10,7 @@
namespace JS {
WeakRefPrototype::WeakRefPrototype(GlobalObject& global_object)
: Object(*global_object.object_prototype())
: PrototypeObject(*global_object.object_prototype())
{
}
@ -31,16 +31,12 @@ WeakRefPrototype::~WeakRefPrototype()
// 26.1.3.2 WeakRef.prototype.deref ( ), https://tc39.es/ecma262/#sec-weak-ref.prototype.deref
JS_DEFINE_NATIVE_FUNCTION(WeakRefPrototype::deref)
{
auto* this_object = vm.this_value(global_object).to_object(global_object);
if (!this_object)
auto* weak_ref = typed_this_object(global_object);
if (vm.exception())
return {};
if (!is<WeakRef>(this_object)) {
vm.throw_exception<TypeError>(global_object, ErrorType::NotAnObjectOfType, "WeakRef");
return {};
}
auto& weak_ref = static_cast<WeakRef&>(*this_object);
weak_ref.update_execution_generation();
return weak_ref.value() ?: js_undefined();
weak_ref->update_execution_generation();
return weak_ref->value() ?: js_undefined();
}
}

5
Userland/Libraries/LibJS/Runtime/WeakRefPrototype.h
View file

@ -6,12 +6,13 @@
#pragma once
#include <LibJS/Runtime/PrototypeObject.h>
#include <LibJS/Runtime/WeakRef.h>
namespace JS {
class WeakRefPrototype final : public Object {
JS_OBJECT(WeakRefPrototype, Object);
class WeakRefPrototype final : public PrototypeObject<WeakRefPrototype, WeakRef> {
JS_PROTOTYPE_OBJECT(WeakRefPrototype, WeakRef, WeakRef);
public:
WeakRefPrototype(GlobalObject&);