From 72a45a472aa3ce4dfc97c68beeebe95b3df34e23 Mon Sep 17 00:00:00 2001 From: Ali Mohammad Pur Date: Tue, 28 Sep 2021 12:34:51 +0330 Subject: [PATCH] LibPthread: Correct nonsensical loop exit condition in RWLock unlock The loop should terminate after the exchange happens, we shouldn't repeat the operation until the count hits zero. Fixes #10241. --- Userland/Libraries/LibPthread/pthread.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibPthread/pthread.cpp b/Userland/Libraries/LibPthread/pthread.cpp index 86f9703f34f..dc1088c72b8 100644 --- a/Userland/Libraries/LibPthread/pthread.cpp +++ b/Userland/Libraries/LibPthread/pthread.cpp @@ -781,8 +781,9 @@ int pthread_rwlock_unlock(pthread_rwlock_t* lockval_p) --count; auto desired = (current & 0xffff0000u) | count; auto did_exchange = AK::atomic_compare_exchange_strong(lockp, current, desired, AK::MemoryOrder::memory_order_release); - if (!did_exchange) - continue; // tough luck, try again. + if (did_exchange) + break; + // tough luck, try again. } // Finally, unlocked at last!