beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibGUI: Allow deleting text editor indent selections in non tab cases

Browse source 
Since 00f51d42d2aeb44ec4813ca13be787c2f5ca55ff we would not allow the
deletion for a selection by typing if it would match the conditions to
indent on pressing tab.

As any single line TextEditor would always match the indent conditions,
it was impossible to replace selected text by typing in a TextBox,
PasswordBox or UrlBox.

A missing return, as pointed out in https://github.com/SerenityOS/serenity/pull/13269#discussion_r900866416
was the cause for the additional checks in
TextEditor::insert_at_cursor_or_replace_selection, described in https://github.com/SerenityOS/serenity/pull/13269#discussion_r901009457
With the early return in place the additional checks are not aiding with
the indented behavior but cause the regression described above.

This patch removes the unnecessary conditions.
This commit is contained in:
networkException 2022-07-10 12:02:19 +02:00 committed by Linus Groh
parent 071b92e920
commit 710fb11c73
Notes: sideshowbarker 2024-07-17 09:33:28 +09:00 
Author: https://github.com/networkException
Commit: https://github.com/SerenityOS/serenity/commit/710fb11c73
Pull-request: https://github.com/SerenityOS/serenity/pull/14536
Reviewed-by: https://github.com/linusg ✅
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibGUI/TextEditor.cpp
View file

@ -1501,7 +1501,7 @@ void TextEditor::insert_at_cursor_or_replace_selection(StringView text)
{
ReflowDeferrer defer(*this);
VERIFY(is_editable());
if (has_selection() && !is_indenting_selection())
if (has_selection())
delete_selection();
// Check if adding a newline leaves the previous line as just whitespace.
@ -1510,8 +1510,7 @@ void TextEditor::insert_at_cursor_or_replace_selection(StringView text)
&& clear_length > 0
&& current_line().leading_spaces() == clear_length;
if (!is_indenting_selection())
execute<InsertTextCommand>(text, m_cursor);
execute<InsertTextCommand>(text, m_cursor);
if (should_clear_last_line) { // If it does leave just whitespace, clear it.
auto const original_cursor_position = cursor();