beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Libraries: Use default constructors/destructors in LibChess

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-26 09:06:06 -07:00 committed by Brian Gianforcaro
parent 11b28c88fc
commit 7030a9b496
Notes: sideshowbarker 2024-07-17 17:34:12 +09:00 
Author: https://github.com/ldm5180
Commit: https://github.com/SerenityOS/serenity/commit/7030a9b496
Pull-request: https://github.com/SerenityOS/serenity/pull/12994
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibChess/UCICommand.h
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, the SerenityOS developers.
* Copyright (c) 2020-2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -46,7 +46,7 @@ public:
virtual String to_string() const = 0;
virtual ~Command() { }
virtual ~Command() = default;
};
class UCICommand : public Command {

6
Userland/Libraries/LibChess/UCIEndpoint.h
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, the SerenityOS developers.
* Copyright (c) 2020-2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -16,7 +16,7 @@ namespace Chess::UCI {
class Endpoint : public Core::Object {
C_OBJECT(Endpoint)
public:
virtual ~Endpoint() override { }
virtual ~Endpoint() override = default;
virtual void handle_uci() { }
virtual void handle_debug(const DebugCommand&) { }
@ -46,7 +46,7 @@ public:
void set_out(RefPtr<Core::IODevice> out) { m_out = out; }
protected:
Endpoint() { }
Endpoint() = default;
Endpoint(NonnullRefPtr<Core::IODevice> in, NonnullRefPtr<Core::IODevice> out);
private: