beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibGfx: Remove a static on a method in a .h file

Browse source 
Methods defined in header files should generally be `inline`,
not `static`.

`static` means that each translation unit will have its own local copy
of the function when the function isn't inlined and it's up to the
linker's identical code folding to hopefully merge the potentially many
copies in the program. `inline` means that the linker can put the
identical copies in a comdat and merge them by name, without having to
compare contents.

No behavior change.
This commit is contained in:
Nico Weber 2023-06-13 19:10:22 -04:00 committed by Andreas Kling
parent edf11b3809
commit 6e0fc5e221
Notes: sideshowbarker 2024-07-18 04:38:32 +09:00 
Author: https://github.com/nico
Commit: https://github.com/SerenityOS/serenity/commit/6e0fc5e221
Pull-request: https://github.com/SerenityOS/serenity/pull/19393
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGfx/Bitmap.h
View file

@ -66,7 +66,7 @@ enum class StorageFormat {
RGBA8888,
};
static StorageFormat determine_storage_format(BitmapFormat format)
inline StorageFormat determine_storage_format(BitmapFormat format)
{
switch (format) {
case BitmapFormat::BGRx8888: