beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 17:10:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibTest: Convert JavaScriptTestRunner's get_test_results() to ErrorOr

Browse source
This commit is contained in:
Linus Groh 2022-01-04 22:39:52 +01:00
parent 29e96eceeb
commit 6c9cf4d31a
Notes: sideshowbarker 2024-07-17 21:38:33 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/6c9cf4d31a7
Pull-request: https://github.com/SerenityOS/serenity/pull/11626
Reviewed-by: https://github.com/IdanHo ✅
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibTest/JavaScriptTestRunner.h
View file

@ -235,16 +235,12 @@ inline AK::Result<NonnullRefPtr<JS::SourceTextModule>, ParserError> parse_module
return script_or_errors.release_value();
}
inline Optional<JsonValue> get_test_results(JS::Interpreter& interpreter)
inline ErrorOr<JsonValue> get_test_results(JS::Interpreter& interpreter)
{
auto results = MUST(interpreter.global_object().get("__TestResults__"));
auto json_string = TRY_OR_DISCARD(JS::JSONObject::stringify_impl(interpreter.global_object(), results, JS::js_undefined(), JS::js_undefined()));
auto json_string = MUST(JS::JSONObject::stringify_impl(interpreter.global_object(), results, JS::js_undefined(), JS::js_undefined()));
auto json = JsonValue::from_string(json_string);
if (json.is_error())
return {};
return json.value();
return JsonValue::from_string(json_string);
}
inline void TestRunner::do_run_single_test(const String& test_path, size_t, size_t)
@ -365,7 +361,7 @@ inline JSFileResult TestRunner::run_file_test(const String& test_path)
g_vm->clear_exception();
auto test_json = get_test_results(*interpreter);
if (!test_json.has_value()) {
if (test_json.is_error()) {
warnln("Received malformed JSON from test \"{}\"", test_path);
cleanup_and_exit();
}