beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Kernel: Unify Kernel task names for consistency

Browse source 
This change unifies the naming convention for kernel tasks.

The goal of this change is to:

- Make the task names more descriptive, so users can more
  easily understand their purpose in System Monitor.

- Unify the naming convention so they are consistent.
This commit is contained in:
Brian Gianforcaro 2022-06-04 21:44:48 -07:00 committed by Linus Groh
parent 5fd3716e2f
commit 6b85b358f8
Notes: sideshowbarker 2024-07-17 10:27:07 +09:00 
Author: https://github.com/bgianfo
Commit: https://github.com/SerenityOS/serenity/commit/6b85b358f8
Pull-request: https://github.com/SerenityOS/serenity/pull/14190
Reviewed-by: https://github.com/linusg ✅
6 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Bus/USB/UHCI/UHCIController.cpp
View file

@ -509,7 +509,7 @@ size_t UHCIController::poll_transfer_queue(QueueHead& transfer_queue)
ErrorOr<void> UHCIController::spawn_port_process()
{
RefPtr<Thread> usb_hotplug_thread;
(void)Process::create_kernel_process(usb_hotplug_thread, TRY(KString::try_create("UHCI hotplug")), [&] {
(void)Process::create_kernel_process(usb_hotplug_thread, TRY(KString::try_create("UHCI Hot Plug Task")), [&] {
for (;;) {
if (m_root_hub)
m_root_hub->check_for_port_updates();

2
Kernel/Net/NetworkTask.cpp
View file

@ -43,7 +43,7 @@ static HashTable<RefPtr<TCPSocket>>* delayed_ack_sockets;
void NetworkTask::spawn()
{
RefPtr<Thread> thread;
auto name = KString::try_create("NetworkTask");
auto name = KString::try_create("Network Task");
if (name.is_error())
TODO();
(void)Process::create_kernel_process(thread, name.release_value(), NetworkTask_main, nullptr);

2
Kernel/Scheduler.cpp
View file

@ -405,7 +405,7 @@ UNMAP_AFTER_INIT void Scheduler::initialize()
VERIFY(s_colonel_process);
VERIFY(idle_thread);
idle_thread->set_priority(THREAD_PRIORITY_MIN);
idle_thread->set_name(KString::must_create("idle thread #0"));
idle_thread->set_name(KString::must_create("Idle Task #0"));
set_idle_thread(idle_thread);
}

6
Kernel/Tasks/FinalizerTask.cpp
View file

@ -11,6 +11,8 @@
namespace Kernel {
static constexpr StringView finalizer_task_name = "Finalizer Task"sv;
static void finalizer_task(void*)
{
Thread::current()->set_priority(THREAD_PRIORITY_LOW);
@ -20,14 +22,14 @@ static void finalizer_task(void*)
if (g_finalizer_has_work.exchange(false, AK::MemoryOrder::memory_order_acq_rel) == true)
Thread::finalize_dying_threads();
else
g_finalizer_wait_queue->wait_forever("FinalizerTask");
g_finalizer_wait_queue->wait_forever(finalizer_task_name);
}
};
UNMAP_AFTER_INIT void FinalizerTask::spawn()
{
RefPtr<Thread> finalizer_thread;
auto finalizer_process = Process::create_kernel_process(finalizer_thread, KString::must_create("FinalizerTask"), finalizer_task, nullptr);
auto finalizer_process = Process::create_kernel_process(finalizer_thread, KString::must_create(finalizer_task_name), finalizer_task, nullptr);
VERIFY(finalizer_process);
g_finalizer = finalizer_thread;
}

4
Kernel/Tasks/SyncTask.cpp
View file

@ -15,8 +15,8 @@ namespace Kernel {
UNMAP_AFTER_INIT void SyncTask::spawn()
{
RefPtr<Thread> syncd_thread;
(void)Process::create_kernel_process(syncd_thread, KString::must_create("SyncTask"), [] {
dbgln("SyncTask is running");
(void)Process::create_kernel_process(syncd_thread, KString::must_create("VFS Sync Task"), [] {
dbgln("VFS SyncTask is running");
for (;;) {
VirtualFileSystem::sync();
(void)Thread::current()->sleep(Time::from_seconds(1));

2
Kernel/WorkQueue.cpp
View file

@ -16,7 +16,7 @@ WorkQueue* g_io_work;
UNMAP_AFTER_INIT void WorkQueue::initialize()
{
g_io_work = new WorkQueue("IO WorkQueue");
g_io_work = new WorkQueue("IO WorkQueue Task");
}
UNMAP_AFTER_INIT WorkQueue::WorkQueue(StringView name)