beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 17:10:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

WebDriver: Implement Switch To Frame for null ID

Browse source 
Fill in a few lines from the spec :^)
This commit is contained in:
Noah Bright 2024-09-21 10:41:00 -04:00 committed by Sam Atkins
parent 44f672bacf
commit 6862796d5e
Notes: github-actions[bot] 2024-09-21 15:48:09 +00:00 
Author: https://github.com/noahmbright
Commit: https://github.com/LadybirdBrowser/ladybird/commit/6862796d5e7
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1472
Reviewed-by: https://github.com/AtkinsSJ ✅
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Userland/Services/WebContent/WebDriverConnection.cpp
View file

@ -526,10 +526,14 @@ Messages::WebDriverClient::SwitchToFrameResponse WebDriverConnection::switch_to_
// -> id is null
if (id.is_null()) {
// FIXME: 1. If session's current top-level browsing context is no longer open, return error with error code no such window.
// FIXME: 2. Try to handle any user prompts with session.
// FIXME: 3. Set the current browsing context with session and session's current top-level browsing context.
dbgln("FIXME: WebDriverConnection::switch_to_frame(id=null)");
// 1. If session's current top-level browsing context is no longer open, return error with error code no such window.
TRY(ensure_current_top_level_browsing_context_is_open());
// 2. Try to handle any user prompts with session.
TRY(handle_any_user_prompts());
// 3. Set the current browsing context with session and session's current top-level browsing context.
m_current_browsing_context = current_top_level_browsing_context();
}
// -> id is a Number object