beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 09:00:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Move generated #include statement for iterators out of loop

Browse source 
When an IDL file has #imports and the IDL interface exposes an iterator,
the bindings generator would generate #include statements missing the
class name of the iterator in the form 'LibWeb/{namespace}/Iterator'.

This change only generates the iterator #include statement for the top
interface that is the iterator.
This commit is contained in:
Kenneth Myhra 2023-03-05 20:46:16 +01:00 committed by Linus Groh
parent 1ef03c9cc5
commit 680e970597
Notes: sideshowbarker 2024-07-17 03:59:29 +09:00 
Author: https://github.com/kennethmyhra
Commit: https://github.com/SerenityOS/serenity/commit/680e970597
Pull-request: https://github.com/SerenityOS/serenity/pull/17729
Reviewed-by: https://github.com/linusg ✅
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
View file

@ -248,11 +248,11 @@ static void emit_includes_for_all_imports(auto& interface, auto& generator, bool
continue;
generate_include_for(generator, interface->module_own_path);
}
if (is_iterator) {
auto iterator_path = DeprecatedString::formatted("{}Iterator", interface->fully_qualified_name.replace("::"sv, "/"sv, ReplaceMode::All));
generate_include_for_iterator(generator, iterator_path);
}
if (is_iterator) {
auto iterator_path = DeprecatedString::formatted("{}Iterator", interface.fully_qualified_name.replace("::"sv, "/"sv, ReplaceMode::All));
generate_include_for_iterator(generator, iterator_path);
}
}