From 67b1f4af5555aff14080488c7154d3278e15cf80 Mon Sep 17 00:00:00 2001 From: Shannon Booth Date: Sun, 26 May 2024 10:53:19 +1200 Subject: [PATCH] LibWeb: Implement HTMLFormElement.encoding --- Tests/LibWeb/Text/expected/HTML/form-element-enctype.txt | 3 +++ Tests/LibWeb/Text/input/HTML/form-element-enctype.html | 3 +++ Userland/Libraries/LibWeb/HTML/HTMLFormElement.idl | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Tests/LibWeb/Text/expected/HTML/form-element-enctype.txt b/Tests/LibWeb/Text/expected/HTML/form-element-enctype.txt index 4e5e08d258d..41989b085d5 100644 --- a/Tests/LibWeb/Text/expected/HTML/form-element-enctype.txt +++ b/Tests/LibWeb/Text/expected/HTML/form-element-enctype.txt @@ -1,5 +1,8 @@ enctype | application/x-www-form-urlencoded +encoding | application/x-www-form-urlencoded enctype | text/plain +encoding | text/plain enctype | application/x-www-form-urlencoded +encoding | application/x-www-form-urlencoded diff --git a/Tests/LibWeb/Text/input/HTML/form-element-enctype.html b/Tests/LibWeb/Text/input/HTML/form-element-enctype.html index 4c9ad01df27..23723113058 100644 --- a/Tests/LibWeb/Text/input/HTML/form-element-enctype.html +++ b/Tests/LibWeb/Text/input/HTML/form-element-enctype.html @@ -5,14 +5,17 @@ const form = document.getElementById('testForm'); println(`enctype | ${form.enctype}`); + println(`encoding | ${form.encoding}`); println(''); form.enctype = 'text/plain'; println(`enctype | ${form.enctype}`); + println(`encoding | ${form.encoding}`); println(''); form.enctype = 'invalid-value'; println(`enctype | ${form.enctype}`); + println(`encoding | ${form.encoding}`); }); diff --git a/Userland/Libraries/LibWeb/HTML/HTMLFormElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLFormElement.idl index 84667f30fe1..605d6f63b83 100644 --- a/Userland/Libraries/LibWeb/HTML/HTMLFormElement.idl +++ b/Userland/Libraries/LibWeb/HTML/HTMLFormElement.idl @@ -19,7 +19,7 @@ interface HTMLFormElement : HTMLElement { [CEReactions] attribute USVString action; [FIXME, CEReactions] attribute DOMString autocomplete; [CEReactions, Enumerated=EnctypeAttribute, Reflect] attribute DOMString enctype; - [FIXME, CEReactions] attribute DOMString encoding; + [CEReactions, Enumerated=EnctypeAttribute, Reflect=enctype] attribute DOMString encoding; [CEReactions] attribute DOMString method; [CEReactions, Reflect] attribute DOMString name; [CEReactions, Reflect=novalidate] attribute boolean noValidate;