beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Convert GeneratorObjectPrototype functions to ThrowCompletionOr

Browse source
This commit is contained in:
Idan Horowitz 2021-10-29 01:07:30 +03:00
parent 7b5ccbc5ed
commit 658056233e
Notes: sideshowbarker 2024-07-18 01:45:58 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/658056233eb
Pull-request: https://github.com/SerenityOS/serenity/pull/10675
Reviewed-by: https://github.com/linusg ✅
2 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibJS/Runtime/GeneratorObjectPrototype.cpp
View file

@ -20,9 +20,9 @@ void GeneratorObjectPrototype::initialize(GlobalObject& global_object)
auto& vm = this->vm();
Object::initialize(global_object);
u8 attr = Attribute::Writable | Attribute::Configurable;
define_old_native_function(vm.names.next, next, 1, attr);
define_old_native_function(vm.names.return_, return_, 1, attr);
define_old_native_function(vm.names.throw_, throw_, 1, attr);
define_native_function(vm.names.next, next, 1, attr);
define_native_function(vm.names.return_, return_, 1, attr);
define_native_function(vm.names.throw_, throw_, 1, attr);
// 27.5.1.5 Generator.prototype [ @@toStringTag ], https://tc39.es/ecma262/#sec-generator.prototype-@@tostringtag
define_direct_property(*vm.well_known_symbol_to_string_tag(), js_string(vm, "Generator"), Attribute::Configurable);
@ -33,24 +33,24 @@ GeneratorObjectPrototype::~GeneratorObjectPrototype()
}
// 27.5.1.2 Generator.prototype.next ( value ), https://tc39.es/ecma262/#sec-generator.prototype.next
JS_DEFINE_OLD_NATIVE_FUNCTION(GeneratorObjectPrototype::next)
JS_DEFINE_NATIVE_FUNCTION(GeneratorObjectPrototype::next)
{
auto* generator_object = TRY_OR_DISCARD(typed_this_object(global_object));
auto* generator_object = TRY(typed_this_object(global_object));
return generator_object->next_impl(vm, global_object, {});
}
// 27.5.1.3 Generator.prototype.next ( value ), https://tc39.es/ecma262/#sec-generator.prototype.return
JS_DEFINE_OLD_NATIVE_FUNCTION(GeneratorObjectPrototype::return_)
JS_DEFINE_NATIVE_FUNCTION(GeneratorObjectPrototype::return_)
{
auto* generator_object = TRY_OR_DISCARD(typed_this_object(global_object));
auto* generator_object = TRY(typed_this_object(global_object));
generator_object->set_done();
return generator_object->next_impl(vm, global_object, {});
}
// 27.5.1.4 Generator.prototype.next ( value ), https://tc39.es/ecma262/#sec-generator.prototype.throw
JS_DEFINE_OLD_NATIVE_FUNCTION(GeneratorObjectPrototype::throw_)
JS_DEFINE_NATIVE_FUNCTION(GeneratorObjectPrototype::throw_)
{
auto* generator_object = TRY_OR_DISCARD(typed_this_object(global_object));
auto* generator_object = TRY(typed_this_object(global_object));
return generator_object->next_impl(vm, global_object, vm.argument(0));
}

6
Userland/Libraries/LibJS/Runtime/GeneratorObjectPrototype.h
View file

@ -21,9 +21,9 @@ public:
virtual ~GeneratorObjectPrototype() override;
private:
JS_DECLARE_OLD_NATIVE_FUNCTION(next);
JS_DECLARE_OLD_NATIVE_FUNCTION(return_);
JS_DECLARE_OLD_NATIVE_FUNCTION(throw_);
JS_DECLARE_NATIVE_FUNCTION(next);
JS_DECLARE_NATIVE_FUNCTION(return_);
JS_DECLARE_NATIVE_FUNCTION(throw_);
};
}