From 637ccacce53ef984f35a8d6d86c262628bcc39f8 Mon Sep 17 00:00:00 2001 From: Daniel Bertalan Date: Tue, 21 May 2024 11:59:32 +0200 Subject: [PATCH] AK: Enable format string checking in Clang builds Format string checking was disabled in Clang-based builds due to a compiler bug: https://github.com/llvm/llvm-project/issues/51182. Now that the requirement has been raised to Clang 17, that is no longer necessary. This has been tested to work correctly with Apple Clang 15.0.0 (which is the *least modern* supported compiler), as well as CLion 2024.1's bundled Clangd. --- AK/CheckedFormatString.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/AK/CheckedFormatString.h b/AK/CheckedFormatString.h index f459e4426b0..b43b3015af1 100644 --- a/AK/CheckedFormatString.h +++ b/AK/CheckedFormatString.h @@ -11,14 +11,6 @@ #include #include -#ifdef ENABLE_COMPILETIME_FORMAT_CHECK -// FIXME: Seems like clang doesn't like calling 'consteval' functions inside 'consteval' functions quite the same way as GCC does, -// it seems to entirely forget that it accepted that parameters to a 'consteval' function to begin with. -# if defined(AK_COMPILER_CLANG) -# undef ENABLE_COMPILETIME_FORMAT_CHECK -# endif -#endif - #ifdef ENABLE_COMPILETIME_FORMAT_CHECK namespace AK::Format::Detail {