beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibGUI: Don't crash when rendering a collapsible toolbar with no items

Browse source 
This prevents a crash in GML Playground that would occur when
previewing a GUI with a collapsible toolbar.
This commit is contained in:
Tim Ledbetter 2024-05-15 06:03:16 +01:00 committed by Andreas Kling
parent 6876c62110
commit 6290f96aa7
Notes: sideshowbarker 2024-07-17 11:06:06 +09:00 
Author: https://github.com/tcl3
Commit: https://github.com/SerenityOS/serenity/commit/6290f96aa7
Pull-request: https://github.com/SerenityOS/serenity/pull/24333
Issue: https://github.com/SerenityOS/serenity/issues/24303
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGUI/Toolbar.cpp
View file

@ -165,7 +165,7 @@ ErrorOr<void> Toolbar::create_overflow_objects()
ErrorOr<void> Toolbar::update_overflow_menu()
{
if (!m_collapsible)
if (!m_collapsible || m_items.is_empty())
return {};
Optional<size_t> marginal_index {};