beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Meta: Fix check for AK test inclusion

Browse source 
basename from GNU coreutils 8.32 (the default on Debian Bullseye, as
bash 5.2.0 does not include basename as a built-in command) does not
accept multiple arguments. This will cause the command to fail with no
output, and the error code not being propagated for some reason. This
means that the loop never gets executed, and thus the check never
actually does anything. This commit fixes that behavior by calling
'basename' multiple times.
This commit is contained in:
Ben Wiederhake 2022-09-12 21:02:11 +02:00 committed by Brian Gianforcaro
parent 1d846e5591
commit 616b3dc718
Notes: sideshowbarker 2024-07-17 08:36:27 +09:00 
Author: https://github.com/BenWiederhake
Commit: https://github.com/SerenityOS/serenity/commit/616b3dc718
Pull-request: https://github.com/SerenityOS/serenity/pull/15216
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Meta/check-ak-test-files.sh
View file

@ -14,7 +14,7 @@ while IFS= read -r FILENAME; do
MISSING_FILES=y
fi
done < <(
git ls-files 'Tests/AK/Test*.cpp' | xargs basename
git ls-files 'Tests/AK/Test*.cpp' | xargs -n1 basename
)
if [ "n" != "${MISSING_FILES}" ] ; then