beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Do not crash when parsing a SVG script element

Browse source 
Just leave a FIXME dbgln message instead. This works around a crash seen
in html5test.com.
This commit is contained in:
Shannon Booth 2023-09-23 10:52:12 +12:00 committed by Andreas Kling
parent 6de9d2820f
commit 60c32f39a1
Notes: sideshowbarker 2024-07-18 05:01:22 +09:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/SerenityOS/serenity/commit/60c32f39a1
Pull-request: https://github.com/SerenityOS/serenity/pull/21197
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp
View file

@ -3545,7 +3545,7 @@ void HTMLParser::process_using_the_rules_for_foreign_content(HTMLToken& token)
m_parser_pause_flag = true; m_parser_pause_flag = true;
// FIXME: If the active speculative HTML parser is null and the user agent supports SVG, then Process the SVG script element according to the SVG rules. [SVG] // FIXME: If the active speculative HTML parser is null and the user agent supports SVG, then Process the SVG script element according to the SVG rules. [SVG]
TODO(); dbgln("FIXME: Missing 'Process the SVG script element according to the SVG rules.");
// Decrement the parser's script nesting level by one. // Decrement the parser's script nesting level by one.
decrement_script_nesting_level(); decrement_script_nesting_level();
@ -3555,7 +3555,9 @@ void HTMLParser::process_using_the_rules_for_foreign_content(HTMLToken& token)
// Let the insertion point have the value of the old insertion point. // Let the insertion point have the value of the old insertion point.
m_tokenizer.restore_insertion_point(); m_tokenizer.restore_insertion_point();
return;
} }
// -> Any other end tag // -> Any other end tag
if (token.is_end_tag()) { if (token.is_end_tag()) {
// 1. Initialize node to be the current node (the bottommost node of the stack). // 1. Initialize node to be the current node (the bottommost node of the stack).