beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 09:00:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

CMake: Reorganize flags for ClangCL usage

Browse source 
Disable some non-supported flags on windows platforms, and
pull in some flags from the other windows support branches.

Co-Authored-By: Andrew Kaster <andrew@ladybird.org>
This commit is contained in:
pheonixfirewingz 2024-10-09 22:38:58 +01:00 committed by Andrew Kaster
parent c92d9cce42
commit 60283ed392
Notes: github-actions[bot] 2024-10-11 03:49:51 +00:00 
Author: https://github.com/pheonixfirewingz
Commit: https://github.com/LadybirdBrowser/ladybird/commit/60283ed392b
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1695
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/AtkinsSJ
Reviewed-by: https://github.com/nico
Reviewed-by: https://github.com/vitalyster
2 changed files with 21 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
Meta/CMake/common_compile_options.cmake
View file

@ -38,10 +38,23 @@ macro(add_swift_link_options)
add_link_options($<$<LINK_LANGUAGE:Swift>:${args}>)
endmacro()
# FIXME: Rework these flags to remove the suspicious ones.
if (WIN32)
add_compile_options(-Wno-unknown-attributes) # [[no_unique_address]] is broken in MSVC ABI until next ABI break
add_compile_options(-Wno-reinterpret-base-class)
add_compile_options(-Wno-microsoft-unqualified-friend) # MSVC doesn't support unqualified friends
add_compile_definitions(_CRT_SECURE_NO_WARNINGS) # _s replacements not desired (or implemented on any other platform other than VxWorks)
add_compile_definitions(_CRT_NONSTDC_NO_WARNINGS) # POSIX names are just fine, thanks
add_compile_definitions(_USE_MATH_DEFINES)
add_compile_definitions(NOMINMAX)
add_compile_definitions(WIN32_LEAN_AND_MEAN)
add_compile_definitions(NAME_MAX=255)
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)
add_compile_options(-Wno-deprecated-declarations)
endif()
if (MSVC)
add_cxx_compile_options(/W4)
# do not warn about unused function
add_cxx_compile_options(/wd4505)
# disable exceptions
add_cxx_compile_options(/EHsc)
# disable floating-point expression contraction
@ -110,4 +123,6 @@ if (NOT WIN32)
add_cxx_link_options(-fstack-protector-strong)
endif()
add_cxx_compile_options(-fstrict-flex-arrays=2)
if (NOT MSVC)
add_cxx_compile_options(-fstrict-flex-arrays=2)
endif()

2
Meta/CMake/lagom_compile_options.cmake
View file

@ -32,7 +32,9 @@ if (CMAKE_BUILD_TYPE STREQUAL "Debug")
add_cxx_compile_options(-Og)
else()
add_cxx_compile_options(-O2)
if (NOT MSVC)
add_cxx_compile_options(-g1)
endif()
endif()
function(add_cxx_linker_flag_if_supported flag)