beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

SystemServer: Fix race condition in Service::determine_account()

Browse source 
In theory our peer process could die between the call to getsockopt()
and Core::system::stat() and another process could end up with the same
PID which would result in us incorrectly launching the service as
another user (e.g. root).
This commit is contained in:
Gunnar Beutner 2022-10-22 19:52:53 +02:00 committed by Linus Groh
parent 5b3980b040
commit 5f38f5500e
Notes: sideshowbarker 2024-07-17 05:13:00 +09:00 
Author: https://github.com/gunnarbeutner
Commit: https://github.com/SerenityOS/serenity/commit/5f38f5500e
Pull-request: https://github.com/SerenityOS/serenity/pull/15752
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Services/SystemServer/Service.cpp
View file

@ -419,10 +419,7 @@ ErrorOr<void> Service::determine_account(int fd)
socklen_t creds_size = sizeof(creds);
TRY(Core::System::getsockopt(fd, SOL_SOCKET, SO_PEERCRED, &creds, &creds_size));
auto const directory_name = String::formatted("/proc/{}/", creds.pid);
auto const stat = TRY(Core::System::stat(directory_name));
m_account = TRY(Core::Account::from_uid(stat.st_uid, Core::Account::Read::PasswdOnly));
m_account = TRY(Core::Account::from_uid(creds.uid, Core::Account::Read::PasswdOnly));
return {};
}