From 5e66eda6884cf4bd796d97beb7b606b70a3c91de Mon Sep 17 00:00:00 2001 From: Rok Povsic Date: Sun, 27 Dec 2020 09:46:08 +0100 Subject: [PATCH] HexEditor: Make single-character selection display proper start/end Previously, -1 / -1 was displayed. Fixes #3555 --- Applications/HexEditor/HexEditor.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Applications/HexEditor/HexEditor.cpp b/Applications/HexEditor/HexEditor.cpp index 0cb11aea6ec..693f3b708bc 100644 --- a/Applications/HexEditor/HexEditor.cpp +++ b/Applications/HexEditor/HexEditor.cpp @@ -229,7 +229,7 @@ void HexEditor::mousedown_event(GUI::MouseEvent& event) m_position = offset; m_in_drag_select = true; m_selection_start = offset; - m_selection_end = -1; + m_selection_end = offset; update(); update_status(); } @@ -250,7 +250,7 @@ void HexEditor::mousedown_event(GUI::MouseEvent& event) m_byte_position = 0; m_in_drag_select = true; m_selection_start = offset; - m_selection_end = -1; + m_selection_end = offset; m_edit_mode = EditMode::Text; update(); update_status(); @@ -314,10 +314,7 @@ void HexEditor::mouseup_event(GUI::MouseEvent& event) { if (event.button() == GUI::MouseButton::Left) { if (m_in_drag_select) { - if (m_selection_end == -1 || m_selection_start == -1) { - m_selection_start = -1; - m_selection_end = -1; - } else if (m_selection_end < m_selection_start) { + if (m_selection_end < m_selection_start) { // lets flip these around auto start = m_selection_end; m_selection_end = m_selection_start;