beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 17:40:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Implement HTMLImageElement.complete according to spec

Browse source 
Now that we use the HTML image loading algorithm from spec, we can
implement complete correctly.

This (finally) fixes an issue where images were not loading on
https://twinings.co.uk/ :^)
This commit is contained in:
Andreas Kling 2023-07-11 07:53:09 +02:00
parent 92bc3d200d
commit 5e24b97275
Notes: sideshowbarker 2024-07-16 23:38:54 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/5e24b97275
Pull-request: https://github.com/SerenityOS/serenity/pull/19939
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/HTMLImageElement.cpp
View file

@ -234,9 +234,11 @@ bool HTMLImageElement::complete() const
return true;
// - The img element's current request's state is completely available and its pending request is null.
if (m_current_request->state() == ImageRequest::State::CompletelyAvailable && !m_pending_request)
return true;
// - The img element's current request's state is broken and its pending request is null.
// FIXME: This is ad-hoc and should be updated once we are loading images via the Fetch mechanism.
if (auto bitmap = current_image_bitmap())
if (m_current_request->state() == ImageRequest::State::Broken && !m_pending_request)
return true;
return false;