beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Make JsonParser correctly parse unsigned values larger than u32

Browse source 
Prior to this, it'd try to stuff them into an i64, which could fail and
give us nothing.
Even though this is an extension we've made to JSON, the parser should
be able to correctly round-trip from whatever our serialiser has
generated.
This commit is contained in:
Ali Mohammad Pur 2021-07-15 03:31:08 +04:30 committed by Andreas Kling
parent 2404ad6897
commit 5d170810db
Notes: sideshowbarker 2024-07-18 09:00:03 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/5d170810dba
Pull-request: https://github.com/SerenityOS/serenity/pull/8760
2 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
AK/JsonParser.cpp
View file

@ -263,9 +263,13 @@ Optional<JsonValue> JsonParser::parse_number()
value = JsonValue((double)whole + ((double)fraction / divider));
} else {
#endif
auto to_unsigned_result = number_string.to_uint();
auto to_unsigned_result = number_string.to_uint<u64>();
if (to_unsigned_result.has_value()) {
value = JsonValue(to_unsigned_result.value());
auto number = *to_unsigned_result;
if (number <= NumericLimits<u32>::max())
value = JsonValue((u32)number);
else
value = JsonValue(number);
} else {
auto number = number_string.to_int<i64>();
if (!number.has_value())

9
Tests/AK/TestJSON.cpp
View file

@ -105,3 +105,12 @@ TEST_CASE(json_duplicate_keys)
json.set("test", "baz");
EXPECT_EQ(json.to_string(), "{\"test\":\"baz\"}");
}
TEST_CASE(json_u64_roundtrip)
{
auto big_value = 0xffffffffffffffffull;
auto json = JsonValue(big_value).to_string();
auto value = JsonValue::from_string(json);
EXPECT_EQ_FORCE(value.has_value(), true);
EXPECT_EQ(value->as_u64(), big_value);
}