beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Fix OBOE in bounds check of ResolvedCSSStyleDeclaration#item

Browse source 
Without this, it would return "(invalid CSS::PropertyID)" when
requesting item(decl.length).
This commit is contained in:
Luke Wilde 2024-11-14 15:37:48 +00:00 committed by Andreas Kling
parent 1a1fb14e26
commit 5aacb053a3
Notes: github-actions[bot] 2024-11-14 18:51:40 +00:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/LadybirdBrowser/ladybird/commit/5aacb053a3f
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2346
3 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/CSS/ResolvedCSSStyleDeclaration.cpp
View file

@ -76,7 +76,7 @@ String ResolvedCSSStyleDeclaration::item(size_t index) const
{
// The item(index) method must return the property name of the CSS declaration at position index.
// FIXME: Return custom properties if index > last_longhand_property_id.
if (index > length())
if (index >= length())
return {};
auto property_id = static_cast<PropertyID>(index + to_underlying(first_longhand_property_id));
return string_from_property_id(property_id).to_string();

1
Tests/LibWeb/Text/expected/css/getComputedStyle-item-does-not-return-invalid-propertyid-on-length-boundary.txt Normal file
View file

@ -0,0 +1 @@
getComputedStyle().item(length) should return empty string: ''

8
Tests/LibWeb/Text/input/css/getComputedStyle-item-does-not-return-invalid-propertyid-on-length-boundary.html Normal file
View file

@ -0,0 +1,8 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<script>
test(() => {
const style = getComputedStyle(document.body);
println(`getComputedStyle().item(length) should return empty string: '${style.item(style.length)}'`);
});
</script>