beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 17:10:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

AK: Address MSVC/Windows portability for logging

Browse source 
`STDERR_FILENO` is pretty common but not part of the standard. On
Windows, in order to get a file number, one must use `_fileno` to
convert the `FILE *` to a file number. Adopt this pattern similar
to the Android path which uses platform specific operations.
This commit is contained in:
Saleem Abdulrasool 2024-10-02 12:58:01 -07:00 committed by Andrew Kaster
parent 1322a7e917
commit 5a35ee08d3
Notes: github-actions[bot] 2024-10-02 23:06:00 +00:00 
Author: https://github.com/compnerd
Commit: https://github.com/LadybirdBrowser/ladybird/commit/5a35ee08d3d
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1605
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
AK/Format.cpp
View file

@ -25,6 +25,10 @@
# include <android/log.h> # include <android/log.h>
#endif #endif
#if defined(AK_OS_WINDOWS)
# include <io.h>
#endif
namespace AK { namespace AK {
class FormatParser : public GenericLexer { class FormatParser : public GenericLexer {
@ -1213,6 +1217,8 @@ void vdbg(StringView fmtstr, TypeErasedFormatParams& params, bool newline)
#ifdef AK_OS_ANDROID #ifdef AK_OS_ANDROID
__android_log_write(ANDROID_LOG_DEBUG, s_log_tag_name, string.characters_without_null_termination()); __android_log_write(ANDROID_LOG_DEBUG, s_log_tag_name, string.characters_without_null_termination());
#elif defined(AK_OS_WINDOWS)
[[maybe_unused]] auto rc = _write(_fileno(stderr), string.characters_without_null_termination(), string.length());
#else #else
[[maybe_unused]] auto rc = write(STDERR_FILENO, string.characters_without_null_termination(), string.length()); [[maybe_unused]] auto rc = write(STDERR_FILENO, string.characters_without_null_termination(), string.length());
#endif #endif