beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

RequestServer: Exit early to avoid executing protocol destructors

Browse source 
I broke this when I made the protocol objects be wrapped by smart
pointers to appease static analysis.

The Protocol base class currently VERIFY's that it's never called.
So to have the best of both worlds until someone actually fixes
the code to do proper de-registration, just call `exit(..)` so the
smart pointers never go out of scope.
This commit is contained in:
Brian Gianforcaro 2021-09-05 10:31:39 -07:00 committed by Andreas Kling
parent 293e7ccfc7
commit 5905d2e9e9
Notes: sideshowbarker 2024-07-18 04:40:09 +09:00 
Author: https://github.com/bgianfo
Commit: https://github.com/SerenityOS/serenity/commit/5905d2e9e93
Pull-request: https://github.com/SerenityOS/serenity/pull/9839
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Userland/Services/RequestServer/Protocol.cpp
View file

@ -31,6 +31,7 @@ Protocol::Protocol(const String& name)
Protocol::~Protocol()
{
// FIXME: Do proper de-registration.
VERIFY_NOT_REACHED();
}

7
Userland/Services/RequestServer/main.cpp
View file

@ -46,5 +46,10 @@ int main(int, char**)
auto socket = Core::LocalSocket::take_over_accepted_socket_from_system_server();
VERIFY(socket);
IPC::new_client_connection<RequestServer::ClientConnection>(socket.release_nonnull(), 1);
return event_loop.exec();
auto result = event_loop.exec();
// FIXME: We exit instead of returning, so that protocol destructors don't get called.
// The Protocol base class should probably do proper de-registration instead of
// just VERIFY_NOT_REACHED().
exit(result);
}