beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 17:10:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibGfx/TIFF: Use a wider type for palette indices to prevent overflow

Browse source 
We refuse any image with a sample depth greater than 32, storing these
value as `u64` prevent any overflows. This is probably overkill as no
one in their right mind will use a 32 bits color table.
This commit is contained in:
Lucas CHOLLET 2024-01-09 19:03:09 -05:00 committed by Andreas Kling
parent 4d1c99e414
commit 58bdca96cd
Notes: sideshowbarker 2024-07-17 07:38:17 +09:00 
Author: https://github.com/LucasChollet
Commit: https://github.com/SerenityOS/serenity/commit/58bdca96cd
Pull-request: https://github.com/SerenityOS/serenity/pull/22674
Reviewed-by: https://github.com/Hendiadyoin1
Reviewed-by: https://github.com/nico ✅
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp
View file

@ -182,10 +182,10 @@ private:
// From description of PhotometricInterpretation in Section 8: Baseline Field Reference Guide
// "In a TIFF ColorMap, all the Red values come first, followed by the Green values,
// then the Blue values."
auto const size = 1 << (*m_metadata.bits_per_sample())[0];
auto const red_offset = 0 * size;
auto const green_offset = 1 * size;
auto const blue_offset = 2 * size;
u64 const size = 1ul << (*m_metadata.bits_per_sample())[0];
u64 const red_offset = 0 * size;
u64 const green_offset = 1 * size;
u64 const blue_offset = 2 * size;
auto const color_map = *m_metadata.color_map();