beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 09:00:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

StringImpl: Fix possible uninitialized access in StringImpl::create().

Browse source 
If the provided length is 0, there's no need to dereference the const char*.
This commit is contained in:
Andreas Kling 2019-06-24 14:36:43 +02:00
parent 643a43f278
commit 583606a2b1
Notes: sideshowbarker 2024-07-19 13:29:27 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/583606a2b1e
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
AK/StringImpl.cpp
View file

@ -76,7 +76,7 @@ RefPtr<StringImpl> StringImpl::create(const char* cstring, int length, ShouldCho
if (!cstring)
return nullptr;
if (!*cstring)
if (!length || !*cstring)
return the_empty_stringimpl();
if (should_chomp) {