From 55af4addc80dddf77f8b36831166101a22bde23a Mon Sep 17 00:00:00 2001 From: Jelle Raaijmakers Date: Thu, 3 Aug 2023 17:45:06 +0200 Subject: [PATCH] CI: Disable aarch64 tests For some reason, the tests are flaky for the aarch64 architecture when running on a CI runner. This causes a lot of unnecessary red crosses for PRs and since the test outcome doesn't seem to be too trustworthy, we are better off not running these tests for now. --- .github/workflows/cmake.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml index 37f8983a07d..75688625eb2 100644 --- a/.github/workflows/cmake.yml +++ b/.github/workflows/cmake.yml @@ -231,12 +231,12 @@ jobs: run: ./check-symbols.sh - name: Create Serenity Rootfs - if: ${{ matrix.debug-options == 'NORMAL_DEBUG'}} + if: ${{ matrix.debug-options == 'NORMAL_DEBUG' }} working-directory: ${{ github.workspace }}/Build/${{ matrix.arch }} run: ninja install && ninja qemu-image - name: Run On-Target Tests - if: ${{ matrix.debug-options == 'NORMAL_DEBUG'}} + if: ${{ matrix.debug-options == 'NORMAL_DEBUG' && matrix.arch != 'aarch64' }} working-directory: ${{ github.workspace }}/Build/${{ matrix.arch }} env: SERENITY_QEMU_CPU: "max,vmx=off" @@ -246,10 +246,6 @@ jobs: echo "::group::ninja run # Qemu output" ninja run echo "::endgroup::" - if ${{ matrix.arch == 'aarch64' }}; then - # FIXME: Actually verify test results when all tests are expected to pass. - exit 0 - fi echo "::group::Verify Output File" mkdir fsmount sudo mount -t ext2 -o loop,rw _disk_image fsmount