beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-23 08:00:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Implement SVGUseElement#href

Browse source 
Required by Ruffle.
b196c8d1bc/web/packages/core/src/shadow-template.ts (L601-L602)
This commit is contained in:
Luke Wilde 2023-11-14 01:03:19 +00:00 committed by Andreas Kling
parent 968bec9844
commit 54972e3ceb
Notes: sideshowbarker 2024-07-16 21:34:08 +09:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/SerenityOS/serenity/commit/54972e3ceb
Pull-request: https://github.com/SerenityOS/serenity/pull/21932
Reviewed-by: https://github.com/awesomekling
5 changed files with 178 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

114
Tests/LibWeb/Text/expected/SVG/svg-href.txt Normal file
View file

@ -0,0 +1,114 @@
---------------
use - no-xlink-href
---------------
element.href instanceof SVGAnimatedString -> true
element.href === element.href -> true
element.href.baseVal ->
element.href.animVal ->
element.href.baseVal === element.href.animVal -> true
element.getAttribute("xlink:href") -> null
element.getAttribute("href") -> null
setting baseVal...
done, new values:
element.href.baseVal -> testSet
element.href.animVal -> testSet
element.href.baseVal === element.href.animVal -> true
element.getAttribute("xlink:href") -> null
element.getAttribute("href") -> testSet
animVal should be readonly:
TypeError: Cannot set property 'animVal' of [object SVGAnimatedString]
---------------
use - explicit-xlink-href
---------------
element.href instanceof SVGAnimatedString -> true
element.href === element.href -> true
element.href.baseVal -> test1
element.href.animVal -> test1
element.href.baseVal === element.href.animVal -> true
element.getAttribute("xlink:href") -> test1
element.getAttribute("href") -> null
setting baseVal...
done, new values:
element.href.baseVal -> testSet
element.href.animVal -> testSet
element.href.baseVal === element.href.animVal -> true
element.getAttribute("xlink:href") -> testSet
element.getAttribute("href") -> null
animVal should be readonly:
TypeError: Cannot set property 'animVal' of [object SVGAnimatedString]
---------------
use - implicit-xlink-href
---------------
element.href instanceof SVGAnimatedString -> true
element.href === element.href -> true
element.href.baseVal -> test2
element.href.animVal -> test2
element.href.baseVal === element.href.animVal -> true
element.getAttribute("xlink:href") -> null
element.getAttribute("href") -> test2
setting baseVal...
done, new values:
element.href.baseVal -> testSet
element.href.animVal -> testSet
element.href.baseVal === element.href.animVal -> true
element.getAttribute("xlink:href") -> null
element.getAttribute("href") -> testSet
animVal should be readonly:
TypeError: Cannot set property 'animVal' of [object SVGAnimatedString]
---------------
textPath - no-xlink-href
---------------
element.href instanceof SVGAnimatedString -> true
element.href === element.href -> true
element.href.baseVal ->
element.href.animVal ->
element.href.baseVal === element.href.animVal -> true
element.getAttribute("xlink:href") -> null
element.getAttribute("href") -> null
setting baseVal...
done, new values:
element.href.baseVal -> testSet
element.href.animVal -> testSet
element.href.baseVal === element.href.animVal -> true
element.getAttribute("xlink:href") -> null
element.getAttribute("href") -> testSet
animVal should be readonly:
TypeError: Cannot set property 'animVal' of [object SVGAnimatedString]
---------------
textPath - explicit-xlink-href
---------------
element.href instanceof SVGAnimatedString -> true
element.href === element.href -> true
element.href.baseVal -> test1
element.href.animVal -> test1
element.href.baseVal === element.href.animVal -> true
element.getAttribute("xlink:href") -> test1
element.getAttribute("href") -> null
setting baseVal...
done, new values:
element.href.baseVal -> testSet
element.href.animVal -> testSet
element.href.baseVal === element.href.animVal -> true
element.getAttribute("xlink:href") -> testSet
element.getAttribute("href") -> null
animVal should be readonly:
TypeError: Cannot set property 'animVal' of [object SVGAnimatedString]
---------------
textPath - implicit-xlink-href
---------------
element.href instanceof SVGAnimatedString -> true
element.href === element.href -> true
element.href.baseVal -> test2
element.href.animVal -> test2
element.href.baseVal === element.href.animVal -> true
element.getAttribute("xlink:href") -> null
element.getAttribute("href") -> test2
setting baseVal...
done, new values:
element.href.baseVal -> testSet
element.href.animVal -> testSet
element.href.baseVal === element.href.animVal -> true
element.getAttribute("xlink:href") -> null
element.getAttribute("href") -> testSet
animVal should be readonly:
TypeError: Cannot set property 'animVal' of [object SVGAnimatedString]

57
Tests/LibWeb/Text/input/SVG/svg-href.html Normal file
View file

@ -0,0 +1,57 @@
<script src="../include.js"></script>
<svg xmlns="http://www.w3.org/2000/svg" id="svg-element">
<use class="no-xlink-href"></use>
<use class="explicit-xlink-href" xlink:href="test1"></use>
<use class="implicit-xlink-href" href="test2"></use>
<text class="ignore">
<textPath class="no-xlink-href"></textPath>
<textPath class="explicit-xlink-href" xlink:href="test1"></textPath>
<textPath class="implicit-xlink-href" href="test2"></textPath>
</text>
</svg>
<script>
function dumpAttribute(element) {
"use strict";
println("---------------");
println(`${element.tagName} - ${element.getAttribute("class")}`);
println("---------------");
println(`element.href instanceof SVGAnimatedString -> ${element.href instanceof SVGAnimatedString}`);
println(`element.href === element.href -> ${element.href === element.href}`);
println(`element.href.baseVal -> ${element.href.baseVal}`);
println(`element.href.animVal -> ${element.href.animVal}`);
println(`element.href.baseVal === element.href.animVal -> ${element.href.baseVal === element.href.animVal}`);
println(`element.getAttribute("xlink:href") -> ${element.getAttribute("xlink:href")}`);
println(`element.getAttribute("href") -> ${element.getAttribute("href")}`);
println("setting baseVal...");
element.href.baseVal = "testSet";
println("done, new values:");
println(`element.href.baseVal -> ${element.href.baseVal}`);
println(`element.href.animVal -> ${element.href.animVal}`);
println(`element.href.baseVal === element.href.animVal -> ${element.href.baseVal === element.href.animVal}`);
println(`element.getAttribute("xlink:href") -> ${element.getAttribute("xlink:href")}`);
println(`element.getAttribute("href") -> ${element.getAttribute("href")}`);
println("animVal should be readonly:")
try {
element.href.animVal = "invalid";
} catch (e) {
println(`${e.name}: ${e.message}`);
}
}
function dumpTree(element) {
for (const child of Array.from(element.children))
{
if (child.getAttribute("class") !== "ignore")
{
dumpAttribute(child);
}
dumpTree(child);
}
}
test(() => {
const svgElement = document.getElementById("svg-element");
dumpTree(svgElement);
});
</script>

1
Userland/Libraries/LibWeb/SVG/SVGUseElement.cpp
View file

@ -44,6 +44,7 @@ void SVGUseElement::initialize(JS::Realm& realm)
void SVGUseElement::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
SVGURIReferenceMixin::visit_edges(visitor);
visitor.visit(m_document_observer);
}

5
Userland/Libraries/LibWeb/SVG/SVGUseElement.h
View file

@ -11,10 +11,13 @@
#include <LibWeb/DOM/DocumentObserver.h>
#include <LibWeb/SVG/SVGAnimatedLength.h>
#include <LibWeb/SVG/SVGGraphicsElement.h>
#include <LibWeb/SVG/SVGURIReference.h>
namespace Web::SVG {
class SVGUseElement final : public SVGGraphicsElement {
class SVGUseElement final
: public SVGGraphicsElement
, public SVGURIReferenceMixin<SupportsXLinkHref::Yes> {
WEB_PLATFORM_OBJECT(SVGUseElement, SVGGraphicsElement);
JS_DECLARE_ALLOCATOR(SVGUseElement);

3
Userland/Libraries/LibWeb/SVG/SVGUseElement.idl
View file

@ -1,6 +1,7 @@
#import <SVG/SVGAnimatedLength.idl>
#import <SVG/SVGElement.idl>
#import <SVG/SVGGraphicsElement.idl>
#import <SVG/SVGURIReference.idl>
// https://svgwg.org/svg2-draft/struct.html#InterfaceSVGUseElement
[Exposed=Window]
@ -13,4 +14,4 @@ interface SVGUseElement : SVGGraphicsElement {
[SameObject] readonly attribute SVGElement? animatedInstanceRoot;
};
// FIXME: SVGUseElement includes SVGURIReference;
SVGUseElement includes SVGURIReference;