beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Implement RegExp.prototype [ @@matchAll ]

Browse source 
This also allows String.prototype.matchAll to work, as all calls to that
method result in an invocation to @@matchAll.
This commit is contained in:
Timothy Flynn 2021-07-15 09:13:56 -04:00 committed by Linus Groh
parent cfddcad7cf
commit 5135f4000c
Notes: sideshowbarker 2024-07-18 08:56:18 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/5135f4000c3
Pull-request: https://github.com/SerenityOS/serenity/pull/8775
Reviewed-by: https://github.com/IdanHo
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/linusg ✅
3 changed files with 130 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
Userland/Libraries/LibJS/Runtime/RegExpPrototype.cpp
View file

@ -13,6 +13,7 @@
#include <LibJS/Runtime/RegExpConstructor.h>
#include <LibJS/Runtime/RegExpObject.h>
#include <LibJS/Runtime/RegExpPrototype.h>
#include <LibJS/Runtime/RegExpStringIterator.h>
#include <LibJS/Token.h>
namespace JS {
@ -32,6 +33,7 @@ void RegExpPrototype::initialize(GlobalObject& global_object)
define_native_function(vm.names.exec, exec, 1, attr);
define_native_function(*vm.well_known_symbol_match(), symbol_match, 1, attr);
define_native_function(*vm.well_known_symbol_match_all(), symbol_match_all, 1, attr);
define_native_function(*vm.well_known_symbol_replace(), symbol_replace, 2, attr);
define_native_function(*vm.well_known_symbol_search(), symbol_search, 1, attr);
define_native_function(*vm.well_known_symbol_split(), symbol_split, 2, attr);
@ -507,6 +509,55 @@ JS_DEFINE_NATIVE_FUNCTION(RegExpPrototype::symbol_match)
}
}
// 22.2.5.8 RegExp.prototype [ @@matchAll ] ( string ), https://tc39.es/ecma262/#sec-regexp-prototype-matchall
JS_DEFINE_NATIVE_FUNCTION(RegExpPrototype::symbol_match_all)
{
auto* regexp_object = this_object_from(vm, global_object);
if (!regexp_object)
return {};
auto string = vm.argument(0).to_string(global_object);
if (vm.exception())
return {};
auto* constructor = species_constructor(global_object, *regexp_object, *global_object.regexp_constructor());
if (vm.exception())
return {};
auto flags_value = regexp_object->get(vm.names.flags);
if (vm.exception())
return {};
auto flags = flags_value.to_string(global_object);
if (vm.exception())
return {};
bool global = flags.find('g').has_value();
bool unicode = flags.find('u').has_value();
MarkedValueList arguments(vm.heap());
arguments.append(regexp_object);
arguments.append(js_string(vm, move(flags)));
auto matcher_value = vm.construct(*constructor, *constructor, move(arguments));
if (vm.exception())
return {};
auto* matcher = matcher_value.to_object(global_object);
if (!matcher)
return {};
auto last_index_value = regexp_object->get(vm.names.lastIndex);
if (vm.exception())
return {};
auto last_index = last_index_value.to_length(global_object);
if (vm.exception())
return {};
matcher->set(vm.names.lastIndex, Value(last_index), true);
if (vm.exception())
return {};
return RegExpStringIterator::create(global_object, *matcher, move(string), global, unicode);
}
// 22.2.5.10 RegExp.prototype [ @@replace ] ( string, replaceValue ), https://tc39.es/ecma262/#sec-regexp.prototype-@@replace
JS_DEFINE_NATIVE_FUNCTION(RegExpPrototype::symbol_replace)
{

1
Userland/Libraries/LibJS/Runtime/RegExpPrototype.h
View file

@ -28,6 +28,7 @@ private:
JS_DECLARE_NATIVE_FUNCTION(test);
JS_DECLARE_NATIVE_FUNCTION(to_string);
JS_DECLARE_NATIVE_FUNCTION(symbol_match);
JS_DECLARE_NATIVE_FUNCTION(symbol_match_all);
JS_DECLARE_NATIVE_FUNCTION(symbol_replace);
JS_DECLARE_NATIVE_FUNCTION(symbol_search);
JS_DECLARE_NATIVE_FUNCTION(symbol_split);

78
Userland/Libraries/LibJS/Tests/builtins/String/String.prototype.matchAll.js Normal file
View file

@ -0,0 +1,78 @@
test("invariants", () => {
expect(String.prototype.matchAll).toHaveLength(1);
});
test("error cases", () => {
[null, undefined].forEach(value => {
expect(() => {
value.matchAll("");
}).toThrow(TypeError);
});
expect(() => {
"hello friends".matchAll(/hello/);
}).toThrow(TypeError);
});
test("basic functionality", () => {
expect("hello friends".matchAll(/hello/g)).not.toBeNull();
expect("hello friends".matchAll(/enemies/g)).not.toBeNull();
{
var iterator = "".matchAll(/a/g);
var next = iterator.next();
expect(next.done).toBeTrue();
expect(next.value).toBeUndefined();
next = iterator.next();
expect(next.done).toBeTrue();
expect(next.value).toBeUndefined();
}
{
var iterator = "a".matchAll(/a/g);
var next = iterator.next();
expect(next.done).toBeFalse();
expect(next.value).toEqual(["a"]);
expect(next.value.index).toBe(0);
next = iterator.next();
expect(next.done).toBeTrue();
expect(next.value).toBeUndefined();
}
{
var iterator = "aa".matchAll(/a/g);
var next = iterator.next();
expect(next.done).toBeFalse();
expect(next.value).toEqual(["a"]);
expect(next.value.index).toBe(0);
next = iterator.next();
expect(next.done).toBeFalse();
expect(next.value).toEqual(["a"]);
expect(next.value.index).toBe(1);
next = iterator.next();
expect(next.done).toBeTrue();
expect(next.value).toBeUndefined();
}
{
var iterator = "aba".matchAll(/a/g);
var next = iterator.next();
expect(next.done).toBeFalse();
expect(next.value).toEqual(["a"]);
expect(next.value.index).toBe(0);
next = iterator.next();
expect(next.done).toBeFalse();
expect(next.value).toEqual(["a"]);
expect(next.value.index).toBe(2);
next = iterator.next();
expect(next.done).toBeTrue();
expect(next.value).toBeUndefined();
}
});