beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Ignore -Wshadow in TRY() and MUST()

Browse source 
This makes the warning in CLion disappear when nesting them.
This commit is contained in:
Linus Groh 2022-12-06 18:19:37 +00:00
parent d2e143eec7
commit 5103e08b77
Notes: sideshowbarker 2024-07-17 03:42:31 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/5103e08b77
Pull-request: https://github.com/SerenityOS/serenity/pull/16338
Reviewed-by: https://github.com/awesomekling ✅
1 changed files with 17 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
AK/Try.h
View file

@ -6,6 +6,8 @@
#pragma once #pragma once
#include <AK/Diagnostics.h>
// NOTE: This macro works with any result type that has the expected APIs. // NOTE: This macro works with any result type that has the expected APIs.
// It's designed with AK::Result and AK::Error in mind. // It's designed with AK::Result and AK::Error in mind.
// //
@ -16,7 +18,9 @@
#define TRY(expression) \ #define TRY(expression) \
({ \ ({ \
auto _temporary_result = (expression); \ /* Ignore -Wshadow to allow nesting the macro. */ \
AK_IGNORE_DIAGNOSTIC("-Wshadow", \
auto _temporary_result = (expression)); \
if (_temporary_result.is_error()) [[unlikely]] \ if (_temporary_result.is_error()) [[unlikely]] \
return _temporary_result.release_error(); \ return _temporary_result.release_error(); \
_temporary_result.release_value(); \ _temporary_result.release_value(); \
@ -24,7 +28,9 @@
#define MUST(expression) \ #define MUST(expression) \
({ \ ({ \
auto _temporary_result = (expression); \ /* Ignore -Wshadow to allow nesting the macro. */ \
AK_IGNORE_DIAGNOSTIC("-Wshadow", \
auto _temporary_result = (expression)); \
VERIFY(!_temporary_result.is_error()); \ VERIFY(!_temporary_result.is_error()); \
_temporary_result.release_value(); \ _temporary_result.release_value(); \
}) })