beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Don't match async \n function as an async function declaration

Browse source
This commit is contained in:
davidot 2021-11-30 15:52:51 +01:00 committed by Linus Groh
parent c2ebaa9d87
commit 5010d4c20c
Notes: sideshowbarker 2024-07-17 23:17:49 +09:00 
Author: https://github.com/davidot
Commit: https://github.com/SerenityOS/serenity/commit/5010d4c20c9
Pull-request: https://github.com/SerenityOS/serenity/pull/11088
Issue: https://github.com/SerenityOS/serenity/issues/11078
Reviewed-by: https://github.com/IdanHo
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/linusg ✅
2 changed files with 27 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
Userland/Libraries/LibJS/Parser.cpp
View file

@ -631,10 +631,15 @@ NonnullRefPtr<Statement> Parser::parse_statement(AllowLabelledFunction allow_lab
return result.release_nonnull();
}
if (match_expression()) {
if (match(TokenType::Function) || (match(TokenType::Async) && next_token().type() == TokenType::Function) || match(TokenType::Class))
if (match(TokenType::Async)) {
auto lookahead_token = next_token();
if (lookahead_token.type() == TokenType::Function && !lookahead_token.trivia_contains_line_terminator())
syntax_error("Async function declaration not allowed in single-statement context");
} else if (match(TokenType::Function) || match(TokenType::Class)) {
syntax_error(String::formatted("{} declaration not allowed in single-statement context", m_state.current_token.name()));
if (match(TokenType::Let) && next_token().type() == TokenType::BracketOpen)
} else if (match(TokenType::Let) && next_token().type() == TokenType::BracketOpen) {
syntax_error(String::formatted("let followed by [ is not allowed in single-statement context"));
}
auto expr = parse_expression(0);
consume_or_insert_semicolon();
@ -3608,11 +3613,15 @@ bool Parser::match_declaration() const
return try_match_let_declaration();
}
if (type == TokenType::Async) {
auto lookahead_token = next_token();
return lookahead_token.type() == TokenType::Function && !lookahead_token.trivia_contains_line_terminator();
}
return type == TokenType::Function
|| type == TokenType::Class
|| type == TokenType::Const
|| type == TokenType::Let
|| (type == TokenType::Async && next_token().type() == TokenType::Function);
|| type == TokenType::Let;
}
Token Parser::next_token() const

15
Userland/Libraries/LibJS/Tests/syntax/async-await.js
View file

@ -1,8 +1,9 @@
describe("parsing freestanding async functions", () => {
test("simple", () => {
expect(`async function foo() {}`).toEval();
// Although it does not create an async function it is valid.
expect(`async
function foo() {}`).not.toEval();
function foo() {}`).toEval();
});
test("await expression", () => {
expect(`async function foo() { await bar(); }`).toEval();
@ -167,6 +168,18 @@ describe("non async function declaration usage of async still works", () => {
const evalResult = eval("async >= 2");
expect(evalResult).toBeTrue();
});
test("async with line ending does not create a function", () => {
expect(() => {
// The ignore is needed otherwise prettier puts a ';' after async.
// prettier-ignore
async
function f() {}
}).toThrowWithMessage(ReferenceError, "'async' is not defined");
expect(`async
function f() { await 3; }`).not.toEval();
});
});
describe("await cannot be used in class static init blocks", () => {