diff --git a/Userland/Libraries/LibKeyboard/CharacterMap.cpp b/Userland/Libraries/LibKeyboard/CharacterMap.cpp index d5b76c710b1..4d661f15bd7 100644 --- a/Userland/Libraries/LibKeyboard/CharacterMap.cpp +++ b/Userland/Libraries/LibKeyboard/CharacterMap.cpp @@ -17,13 +17,11 @@ namespace Keyboard { #ifndef KERNEL // The Kernel explicitly and exclusively links only this file into it. // Thus, we cannot even include a reference to the symbol `CharacterMapFile::load_from_file`. -Optional CharacterMap::load_from_file(const String& map_name) +ErrorOr CharacterMap::load_from_file(const String& map_name) { - auto result = CharacterMapFile::load_from_file(map_name); - if (!result.has_value()) - return {}; + auto result = TRY(CharacterMapFile::load_from_file(map_name)); - return CharacterMap(map_name, result.value()); + return CharacterMap(map_name, result); } #endif diff --git a/Userland/Libraries/LibKeyboard/CharacterMap.h b/Userland/Libraries/LibKeyboard/CharacterMap.h index b1338953f1a..b4d00477db8 100644 --- a/Userland/Libraries/LibKeyboard/CharacterMap.h +++ b/Userland/Libraries/LibKeyboard/CharacterMap.h @@ -19,7 +19,7 @@ class CharacterMap { public: CharacterMap(const String& map_name, const CharacterMapData& map_data); - static Optional load_from_file(const String& filename); + static ErrorOr load_from_file(const String& filename); #ifndef KERNEL int set_system_map(); diff --git a/Userland/Libraries/LibKeyboard/CharacterMapFile.cpp b/Userland/Libraries/LibKeyboard/CharacterMapFile.cpp index 88f2df9b412..233e94e7939 100644 --- a/Userland/Libraries/LibKeyboard/CharacterMapFile.cpp +++ b/Userland/Libraries/LibKeyboard/CharacterMapFile.cpp @@ -11,7 +11,7 @@ namespace Keyboard { -Optional CharacterMapFile::load_from_file(const String& filename) +ErrorOr CharacterMapFile::load_from_file(const String& filename) { auto path = filename; if (!path.ends_with(".json")) { @@ -22,20 +22,10 @@ Optional CharacterMapFile::load_from_file(const String& filena path = full_path.to_string(); } - auto file = Core::File::construct(path); - file->open(Core::OpenMode::ReadOnly); - if (!file->is_open()) { - dbgln("Failed to open {}: {}", path, file->error_string()); - return {}; - } - + auto file = TRY(Core::File::open(path, Core::OpenMode::ReadOnly)); auto file_contents = file->read_all(); - auto json_result = JsonValue::from_string(file_contents); - if (json_result.is_error()) { - dbgln("Failed to load character map from file {}", path); - return {}; - } - auto json = json_result.value().as_object(); + auto json_result = TRY(JsonValue::from_string(file_contents)); + const auto& json = json_result.as_object(); Vector map = read_map(json, "map"); Vector shift_map = read_map(json, "shift_map"); diff --git a/Userland/Libraries/LibKeyboard/CharacterMapFile.h b/Userland/Libraries/LibKeyboard/CharacterMapFile.h index c11800d6129..986278f71a0 100644 --- a/Userland/Libraries/LibKeyboard/CharacterMapFile.h +++ b/Userland/Libraries/LibKeyboard/CharacterMapFile.h @@ -14,7 +14,7 @@ namespace Keyboard { class CharacterMapFile { public: - static Optional load_from_file(const String& filename); + static ErrorOr load_from_file(const String& filename); private: static Vector read_map(const JsonObject& json, const String& name); diff --git a/Userland/Utilities/keymap.cpp b/Userland/Utilities/keymap.cpp index 52fe2ddec88..d92977684a4 100644 --- a/Userland/Utilities/keymap.cpp +++ b/Userland/Utilities/keymap.cpp @@ -34,7 +34,7 @@ ErrorOr serenity_main(Main::Arguments arguments) } auto character_map = Keyboard::CharacterMap::load_from_file(path); - if (!character_map.has_value()) { + if (character_map.is_error()) { warnln("Cannot read keymap {}", path); warnln("Hint: Must be either a keymap name (e.g. 'en-us') or a full path."); return 1;