beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Make Interpreter::call() this_value a required argument

Browse source 
Right now the default is an empty value, which we accidentally exposed
in set{Interval,Timeout}() by not providing a custom this value, which
should't happen at all. Let's just make it a required argument instead.
This commit is contained in:
Linus Groh 2020-05-21 13:41:54 +01:00 committed by Andreas Kling
parent 14dffe4721
commit 4e657c370c
Notes: sideshowbarker 2024-07-19 06:17:02 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/4e657c370c0
Pull-request: https://github.com/SerenityOS/serenity/pull/2319
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/Interpreter.h
View file

@ -104,7 +104,7 @@ public:
void enter_scope(const ScopeNode&, ArgumentVector, ScopeType);
void exit_scope(const ScopeNode&);
Value call(Function&, Value this_value = {}, Optional<MarkedValueList> arguments = {});
Value call(Function&, Value this_value, Optional<MarkedValueList> arguments = {});
Value construct(Function&, Function& new_target, Optional<MarkedValueList> arguments = {});
CallFrame& push_call_frame()