beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Make iframe insertion steps check the shadow including root

Browse source 
The insertion steps for iframes were following an old version of the
spec, where it was checking if the iframe was "in a document tree",
which doesn't cross shadow root boundaries. The spec has since been
updated to check the shadow including root instead.

This is now needed for Cloudflare Turnstile iframe widgets to appear,
as they are now inserted into a shadow root.
This commit is contained in:
Luke Wilde 2024-11-12 18:16:08 +00:00 committed by Andreas Kling
parent 6df4e5f5e7
commit 4dd14d812f
Notes: github-actions[bot] 2024-11-13 13:40:57 +00:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/LadybirdBrowser/ladybird/commit/4dd14d812f7
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2310
3 changed files with 46 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
Libraries/LibWeb/HTML/HTMLIFrameElement.cpp
View file

@ -66,17 +66,26 @@ void HTMLIFrameElement::inserted()
{
HTMLElement::inserted();
// When an iframe element element is inserted into a document whose browsing context is non-null, the user agent must run these steps:
if (in_a_document_tree() && document().browsing_context() && document().is_fully_active()) {
// 1. Create a new child navigable for element.
MUST(create_new_child_navigable(JS::create_heap_function(realm().heap(), [this] {
// 3. Process the iframe attributes for element, with initialInsertion set to true.
process_the_iframe_attributes(true);
set_content_navigable_initialized();
})));
// The iframe HTML element insertion steps, given insertedNode, are:
// 1. If insertedNode's shadow-including root's browsing context is null, then return.
if (!is<DOM::Document>(shadow_including_root()))
return;
// FIXME: 2. If element has a sandbox attribute, then parse the sandboxing directive given the attribute's value and element's iframe sandboxing flag set.
}
DOM::Document& document = verify_cast<DOM::Document>(shadow_including_root());
// NOTE: The check for "not fully active" is to prevent a crash on the dom/nodes/node-appendchild-crash.html WPT test.
if (!document.browsing_context() || !document.is_fully_active())
return;
// 2. Create a new child navigable for insertedNode.
MUST(create_new_child_navigable(JS::create_heap_function(realm().heap(), [this] {
// FIXME: 3. If insertedNode has a sandbox attribute, then parse the sandboxing directive given the attribute's
// value and insertedNode's iframe sandboxing flag set.
// 4. Process the iframe attributes for insertedNode, with initialInsertion set to true.
process_the_iframe_attributes(true);
set_content_navigable_initialized();
})));
}
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#process-the-iframe-attributes

2
Tests/LibWeb/Text/expected/HTML/iframe-successfully-loads-in-shadow-root.txt Normal file
View file

@ -0,0 +1,2 @@
Received a message: 'Hello from iframe in the shadow root of the just inserted div!'
Was it from the shadow root iframe? true

25
Tests/LibWeb/Text/input/HTML/iframe-successfully-loads-in-shadow-root.html Normal file
View file

@ -0,0 +1,25 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<script>
asyncTest((done) => {
const div = document.createElement("div");
const shadowRoot = div.attachShadow({ mode: "closed" });
const iframe = document.createElement("iframe");
window.addEventListener("message", (messageEvent) => {
println(`Received a message: '${messageEvent.data}'`);
println(`Was it from the shadow root iframe? ${messageEvent.source === iframe.contentWindow}`);
done();
});
iframe.srcdoc = `
\u003cscript\u003e
window.parent.postMessage("Hello from iframe in the shadow root of the just inserted div!");
\u003c/script\u003e
`;
shadowRoot.appendChild(iframe);
document.body.appendChild(div);
});
</script>