beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Do not count arguments as env binding when local variable is used

Browse source 
This is a follow up for 210a5d77dc that
actually allows to skip function environment allocation.
This commit is contained in:
Aliaksandr Kalenik 2024-05-21 14:27:15 +01:00 committed by Alexander Kalenik
parent 38b51b791e
commit 4d37b9e715
Notes: sideshowbarker 2024-07-17 06:20:50 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/4d37b9e715
Pull-request: https://github.com/SerenityOS/serenity/pull/24403
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp
View file

@ -212,13 +212,16 @@ ECMAScriptFunctionObject::ECMAScriptFunctionObject(DeprecatedFlyString name, Byt
HashMap<DeprecatedFlyString, ParameterIsLocal> parameter_bindings; HashMap<DeprecatedFlyString, ParameterIsLocal> parameter_bindings;
auto arguments_object_needs_binding = m_arguments_object_needed && !m_local_variables_names.contains_slow(vm().names.arguments.as_string());
// 22. If argumentsObjectNeeded is true, then // 22. If argumentsObjectNeeded is true, then
if (m_arguments_object_needed) { if (m_arguments_object_needed) {
// f. Let parameterBindings be the list-concatenation of parameterNames and « "arguments" ». // f. Let parameterBindings be the list-concatenation of parameterNames and « "arguments" ».
parameter_bindings = m_parameter_names; parameter_bindings = m_parameter_names;
parameter_bindings.set(vm().names.arguments.as_string(), ParameterIsLocal::No); parameter_bindings.set(vm().names.arguments.as_string(), ParameterIsLocal::No);
(*environment_size)++; if (arguments_object_needs_binding)
(*environment_size)++;
} else { } else {
parameter_bindings = m_parameter_names; parameter_bindings = m_parameter_names;
// a. Let parameterBindings be parameterNames. // a. Let parameterBindings be parameterNames.
@ -328,7 +331,6 @@ ECMAScriptFunctionObject::ECMAScriptFunctionObject(DeprecatedFlyString name, Byt
})); }));
} }
auto arguments_object_needs_binding = m_arguments_object_needed && !m_local_variables_names.contains_slow(vm().names.arguments.as_string());
m_function_environment_needed = arguments_object_needs_binding || m_function_environment_bindings_count > 0 || m_var_environment_bindings_count > 0 || m_lex_environment_bindings_count > 0 || uses_this == UsesThis::Yes || m_contains_direct_call_to_eval; m_function_environment_needed = arguments_object_needs_binding || m_function_environment_bindings_count > 0 || m_var_environment_bindings_count > 0 || m_lex_environment_bindings_count > 0 || uses_this == UsesThis::Yes || m_contains_direct_call_to_eval;
} }