beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-27 01:50:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibGfx: Use safe version of count_leading_zeroes() in WOFF parsers

Browse source 
This guards against undefined behavior when zero is given as an
argument.
This commit is contained in:
Tim Ledbetter 2023-10-26 23:47:08 +01:00 committed by Andreas Kling
parent 88bd7d83ad
commit 4b5b8fc564
Notes: sideshowbarker 2024-07-17 00:59:43 +09:00 
Author: https://github.com/tcl3
Commit: https://github.com/SerenityOS/serenity/commit/4b5b8fc564
Pull-request: https://github.com/SerenityOS/serenity/pull/21613
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGfx/Font/WOFF/Font.cpp
View file

@ -65,7 +65,7 @@ static u16 pow_2_less_than_or_equal(u16 x)
{
VERIFY(x > 0);
VERIFY(x < 32769);
return 1 << (sizeof(u16) * 8 - count_leading_zeroes<u16>(x - 1));
return 1 << (sizeof(u16) * 8 - count_leading_zeroes_safe<u16>(x - 1));
}
ErrorOr<NonnullRefPtr<Font>> Font::try_load_from_file(DeprecatedString path, unsigned int index)

2
Userland/Libraries/LibGfx/Font/WOFF2/Font.cpp
View file

@ -113,7 +113,7 @@ static u16 pow_2_less_than_or_equal(u16 x)
{
VERIFY(x > 0);
VERIFY(x < 32769);
return 1 << (sizeof(u16) * 8 - count_leading_zeroes<u16>(x - 1));
return 1 << (sizeof(u16) * 8 - count_leading_zeroes_safe<u16>(x - 1));
}
enum class TransformationVersion {