beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibJS: Skip bindings creation for locals during block declaration init

Browse source 
No need to create bindings for local variables as their values are not
stored in an environment.
This commit is contained in:
Aliaksandr Kalenik 2023-07-09 20:01:22 +02:00 committed by Andreas Kling
parent 47eaef9b41
commit 4a9a1d1656
Notes: sideshowbarker 2024-07-17 03:03:15 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/4a9a1d1656
Pull-request: https://github.com/SerenityOS/serenity/pull/19906
Reviewed-by: https://github.com/awesomekling ✅
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/AST.cpp
View file

@ -4757,7 +4757,13 @@ void ScopeNode::block_declaration_instantiation(VM& vm, Environment* environment
auto is_constant_declaration = declaration.is_constant_declaration();
// NOTE: Due to the use of MUST with `create_immutable_binding` and `create_mutable_binding` below,
// an exception should not result from `for_each_bound_name`.
MUST(declaration.for_each_bound_name([&](auto const& name) {
MUST(declaration.for_each_bound_identifier([&](auto const& identifier) {
if (vm.bytecode_interpreter_if_exists() && identifier.is_local()) {
// NOTE: No need to create bindings for local variables as their values are not stored in an environment.
return;
}
auto const& name = identifier.string();
if (is_constant_declaration) {
MUST(environment->create_immutable_binding(vm, name, true));
} else {