beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Avoid RequireObjectCoercible when creating super references

Browse source 
This is part of an old normative change that happened soon after
Andreas made `super` closer to spec in 1270df2.
See https://github.com/tc39/ecma262/pull/2267/

This was introduced into bytecode by virtue of copy and paste :^)

Bytecode results:
Summary:
    Diff Tests:
        +2 ✅    -2 ❌
This commit is contained in:
Luke Wilde 2023-07-02 20:19:05 +01:00 committed by Andreas Kling
parent b271d9a6bf
commit 442ca4f9b4
Notes: sideshowbarker 2024-07-18 02:47:59 +09:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/SerenityOS/serenity/commit/442ca4f9b4
Pull-request: https://github.com/SerenityOS/serenity/pull/19820
Reviewed-by: https://github.com/Hendiadyoin1
2 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibJS/Bytecode/Op.cpp
View file

@ -660,10 +660,7 @@ ThrowCompletionOr<void> ResolveSuperBase::execute_impl(Bytecode::Interpreter& in
VERIFY(env.has_super_binding()); VERIFY(env.has_super_binding());
// 3. Let baseValue be ? env.GetSuperBase(). // 3. Let baseValue be ? env.GetSuperBase().
auto base_value = TRY(env.get_super_base()); interpreter.accumulator() = TRY(env.get_super_base());
// 4. Let bv be ? RequireObjectCoercible(baseValue).
interpreter.accumulator() = TRY(require_object_coercible(vm, base_value));
return {}; return {};
} }

7
Userland/Libraries/LibJS/Runtime/AbstractOperations.cpp
View file

@ -513,11 +513,8 @@ ThrowCompletionOr<Reference> make_super_property_reference(VM& vm, Value actual_
// 3. Let baseValue be ? env.GetSuperBase(). // 3. Let baseValue be ? env.GetSuperBase().
auto base_value = TRY(env.get_super_base()); auto base_value = TRY(env.get_super_base());
// 4. Let bv be ? RequireObjectCoercible(baseValue). // 4. Return the Reference Record { [[Base]]: baseValue, [[ReferencedName]]: propertyKey, [[Strict]]: strict, [[ThisValue]]: actualThis }.
auto bv = TRY(require_object_coercible(vm, base_value)); return Reference { base_value, property_key, actual_this, strict };
// 5. Return the Reference Record { [[Base]]: bv, [[ReferencedName]]: propertyKey, [[Strict]]: strict, [[ThisValue]]: actualThis }.
return Reference { bv, property_key, actual_this, strict };
} }
// 19.2.1.1 PerformEval ( x, strictCaller, direct ), https://tc39.es/ecma262/#sec-performeval // 19.2.1.1 PerformEval ( x, strictCaller, direct ), https://tc39.es/ecma262/#sec-performeval