beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Meta: Document that clang-15 is required, and update the compiler checks

Browse source 
We require clang-15 for consteval.
This commit is contained in:
Timothy Flynn 2023-06-19 11:00:12 -04:00 committed by Tim Flynn
parent b4939295c2
commit 421aa8da1e
Notes: sideshowbarker 2024-07-17 02:21:14 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/421aa8da1e
Pull-request: https://github.com/SerenityOS/serenity/pull/19482
Reviewed-by: https://github.com/BertalanD ✅
Reviewed-by: https://github.com/caoimhebyrne ✅
Reviewed-by: https://github.com/nico ✅
4 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Documentation/BuildInstructions.md
View file

@ -11,9 +11,9 @@ sudo apt install build-essential cmake curl libmpfr-dev libmpc-dev libgmp-dev e2
```
Optional: `fuse2fs` for [building images without root](https://github.com/SerenityOS/serenity/pull/11224).
#### GCC 12 or Clang 14
#### GCC 12 or Clang 15
A host compiler that supports C++20 features is required for building host tools, the newer the better. Tested versions include gcc-12 and clang-14.
A host compiler that supports C++20 features is required for building host tools, the newer the better. Tested versions include gcc-12 and clang-15.
On Ubuntu gcc-12 is available in the repositories of 22.04 (Jammy) and later.
If you are running an older version, you will either need to upgrade, or find an alternative installation source.

2
Documentation/BuildInstructionsLadybird.md
View file

@ -2,7 +2,7 @@
## Build Prerequisites
Qt6 development packages and a C++20 capable compiler are required. gcc-12 or clang-14 are required at a minimum for c++20 support.
Qt6 development packages and a C++20 capable compiler are required. gcc-12 or clang-15 are required at a minimum for c++20 support.
On Debian/Ubuntu required packages include, but are not limited to:

2
Meta/Lagom/BuildFuzzers.sh
View file

@ -14,7 +14,7 @@ die() {
pick_clang() {
local BEST_VERSION=0
for CLANG_CANDIDATE in clang clang-14 clang-15 clang-16 /opt/homebrew/opt/llvm/bin/clang ; do
for CLANG_CANDIDATE in clang clang-15 clang-16 /opt/homebrew/opt/llvm/bin/clang ; do
if ! command -v $CLANG_CANDIDATE >/dev/null 2>&1; then
continue
fi

8
Meta/serenity.sh
View file

@ -157,7 +157,7 @@ is_supported_compiler() {
[ "$BUILD_VERSION" -ge 14030022 ] && return 0
elif $COMPILER --version 2>&1 | grep "clang" >/dev/null; then
# Clang version check
[ "$MAJOR_VERSION" -ge 14 ] && return 0
[ "$MAJOR_VERSION" -ge 15 ] && return 0
else
# GCC version check
[ "$MAJOR_VERSION" -ge 12 ] && return 0
@ -191,7 +191,7 @@ pick_host_compiler() {
return
fi
find_newest_compiler clang clang-14 clang-15 clang-16 /opt/homebrew/opt/llvm/bin/clang
find_newest_compiler clang clang-15 clang-16 /opt/homebrew/opt/llvm/bin/clang
if is_supported_compiler "$HOST_COMPILER"; then
export CC="${HOST_COMPILER}"
export CXX="${HOST_COMPILER/clang/clang++}"
@ -206,9 +206,9 @@ pick_host_compiler() {
fi
if [ "$(uname -s)" = "Darwin" ]; then
die "Please make sure that Xcode 14.3, Homebrew Clang 14, or higher is installed."
die "Please make sure that Xcode 14.3, Homebrew Clang 15, or higher is installed."
else
die "Please make sure that GCC version 12, Clang version 14, or higher is installed."
die "Please make sure that GCC version 12, Clang version 15, or higher is installed."
fi
}