beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 09:00:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb+LibWebView+WebContent: Remove unused layout notification IPC

Browse source
This commit is contained in:
Timothy Flynn 2024-11-07 14:09:42 -05:00 committed by Andreas Kling
parent 0345c67e14
commit 41a812156c
Notes: github-actions[bot] 2024-11-07 21:54:06 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/41a812156cd
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2212
5 changed files with 1 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibWebView/ViewImplementation.h
View file

@ -159,7 +159,6 @@ public:
void enable_inspector_prototype();
Function<void(Gfx::IntSize)> on_did_layout;
Function<void()> on_ready_to_paint;
Function<String(Web::HTML::ActivateTab, Web::HTML::WebViewHints, Optional<u64>)> on_new_web_view;
Function<void()> on_activate_tab;

8
Userland/Libraries/LibWebView/WebContentClient.cpp
View file

@ -119,14 +119,6 @@ void WebContentClient::did_request_cursor_change(u64 page_id, i32 cursor_type)
}
}
void WebContentClient::did_layout(u64 page_id, Gfx::IntSize content_size)
{
if (auto view = view_for_page_id(page_id); view.has_value()) {
if (view->on_did_layout)
view->on_did_layout(content_size);
}
}
void WebContentClient::did_change_title(u64 page_id, ByteString const& title)
{
if (auto process = WebView::Application::the().find_process(m_process_handle.pid); process.has_value())

1
Userland/Libraries/LibWebView/WebContentClient.h
View file

@ -53,7 +53,6 @@ private:
virtual void did_finish_loading(u64 page_id, URL::URL const&) override;
virtual void did_request_refresh(u64 page_id) override;
virtual void did_request_cursor_change(u64 page_id, i32) override;
virtual void did_layout(u64 page_id, Gfx::IntSize) override;
virtual void did_change_title(u64 page_id, ByteString const&) override;
virtual void did_change_url(u64 page_id, URL::URL const&) override;
virtual void did_request_tooltip_override(u64 page_id, Gfx::IntPoint, ByteString const&) override;

2
Userland/Services/WebContent/PageClient.cpp
View file

@ -229,11 +229,11 @@ void PageClient::page_did_layout()
{
auto* layout_root = this->layout_root();
VERIFY(layout_root);
if (layout_root->paintable_box()->has_scrollable_overflow())
m_content_size = page().enclosing_device_rect(layout_root->paintable_box()->scrollable_overflow_rect().value()).size();
else
m_content_size = page().enclosing_device_rect(layout_root->paintable_box()->absolute_rect()).size();
client().async_did_layout(m_id, m_content_size.to_type<int>());
}
void PageClient::page_did_change_title(ByteString const& title)

1
Userland/Services/WebContent/WebContentClient.ipc
View file

@ -25,7 +25,6 @@ endpoint WebContentClient
did_request_refresh(u64 page_id) =|
did_paint(u64 page_id, Gfx::IntRect content_rect, i32 bitmap_id) =|
did_request_cursor_change(u64 page_id, i32 cursor_type) =|
did_layout(u64 page_id, Gfx::IntSize content_size) =|
did_change_title(u64 page_id, ByteString title) =|
did_change_url(u64 page_id, URL::URL url) =|
did_request_tooltip_override(u64 page_id, Gfx::IntPoint position, ByteString title) =|