beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb+LibWebView+WebContent: Remove unused back/forward navigation IPCs

Browse source
This commit is contained in:
Timothy Flynn 2024-11-05 16:31:00 -05:00 committed by Andreas Kling
parent 1a8a3979f9
commit 413cf6b329
Notes: github-actions[bot] 2024-11-06 09:55:09 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/413cf6b329c
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2183
6 changed files with 0 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Page/Page.h
View file

@ -311,8 +311,6 @@ public:
virtual void paint(DevicePixelRect const&, Painting::BackingStore&, PaintOptions = {}) = 0;
virtual void page_did_change_title(ByteString const&) { }
virtual void page_did_change_url(URL::URL const&) { }
virtual void page_did_request_navigate_back() { }
virtual void page_did_request_navigate_forward() { }
virtual void page_did_request_refresh() { }
virtual void page_did_request_resize_window(Gfx::IntSize) { }
virtual void page_did_request_reposition_window(Gfx::IntPoint) { }

12
Userland/Libraries/LibWebView/WebContentClient.cpp
View file

@ -100,18 +100,6 @@ void WebContentClient::did_find_in_page(u64 page_id, size_t current_match_index,
}
}
void WebContentClient::did_request_navigate_back(u64 page_id)
{
if (auto view = view_for_page_id(page_id); view.has_value())
view->traverse_the_history_by_delta(-1);
}
void WebContentClient::did_request_navigate_forward(u64 page_id)
{
if (auto view = view_for_page_id(page_id); view.has_value())
view->traverse_the_history_by_delta(1);
}
void WebContentClient::did_request_refresh(u64 page_id)
{
if (auto view = view_for_page_id(page_id); view.has_value())

2
Userland/Libraries/LibWebView/WebContentClient.h
View file

@ -51,8 +51,6 @@ private:
virtual void did_paint(u64 page_id, Gfx::IntRect const&, i32) override;
virtual void did_finish_loading(u64 page_id, URL::URL const&) override;
virtual void did_request_navigate_back(u64 page_id) override;
virtual void did_request_navigate_forward(u64 page_id) override;
virtual void did_request_refresh(u64 page_id) override;
virtual void did_request_cursor_change(u64 page_id, i32) override;
virtual void did_layout(u64 page_id, Gfx::IntSize) override;

10
Userland/Services/WebContent/PageClient.cpp
View file

@ -246,16 +246,6 @@ void PageClient::page_did_change_url(URL::URL const& url)
client().async_did_change_url(m_id, url);
}
void PageClient::page_did_request_navigate_back()
{
client().async_did_request_navigate_back(m_id);
}
void PageClient::page_did_request_navigate_forward()
{
client().async_did_request_navigate_forward(m_id);
}
void PageClient::page_did_request_refresh()
{
client().async_did_request_refresh(m_id);

2
Userland/Services/WebContent/PageClient.h
View file

@ -109,8 +109,6 @@ private:
virtual void page_did_layout() override;
virtual void page_did_change_title(ByteString const&) override;
virtual void page_did_change_url(URL::URL const&) override;
virtual void page_did_request_navigate_back() override;
virtual void page_did_request_navigate_forward() override;
virtual void page_did_request_refresh() override;
virtual void page_did_request_resize_window(Gfx::IntSize) override;
virtual void page_did_request_reposition_window(Gfx::IntPoint) override;

2
Userland/Services/WebContent/WebContentClient.ipc
View file

@ -22,8 +22,6 @@ endpoint WebContentClient
{
did_start_loading(u64 page_id, URL::URL url, bool is_redirect) =|
did_finish_loading(u64 page_id, URL::URL url) =|
did_request_navigate_back(u64 page_id) =|
did_request_navigate_forward(u64 page_id) =|
did_request_refresh(u64 page_id) =|
did_paint(u64 page_id, Gfx::IntRect content_rect, i32 bitmap_id) =|
did_request_cursor_change(u64 page_id, i32 cursor_type) =|