mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-11-25 00:50:22 +00:00
Meta: Add a check for periods on the end of titles to commit linter
This commit is contained in:
parent
04f26183cb
commit
3f08e957d4
Notes:
sideshowbarker
2024-07-18 18:03:33 +09:00
Author: https://github.com/IdanHo Commit: https://github.com/SerenityOS/serenity/commit/3f08e957d46 Pull-request: https://github.com/SerenityOS/serenity/pull/7161 Reviewed-by: https://github.com/linusg
2 changed files with 12 additions and 0 deletions
8
.github/workflows/cmake.yml
vendored
8
.github/workflows/cmake.yml
vendored
|
@ -265,6 +265,14 @@ jobs:
|
|||
pattern: '^\S.*?: .+'
|
||||
error: 'Missing category in commit title (if this is a fix up of a previous commit, it should be squashed)'
|
||||
|
||||
- name: Check title
|
||||
if: ${{ success() || failure() }}
|
||||
uses: tim-actions/commit-message-checker-with-regex@v0.3.1
|
||||
with:
|
||||
commits: ${{ steps.get-pr-commits.outputs.commits }}
|
||||
pattern: '^.+[^.\n](\n.*)*$'
|
||||
error: 'Commit title ends in a period'
|
||||
|
||||
notify_irc:
|
||||
needs: [build_and_test_serenity, build_and_test_lagom, lint_commits]
|
||||
runs-on: ubuntu-20.04
|
||||
|
|
|
@ -28,6 +28,10 @@ while read -r line; do
|
|||
error "Missing category in commit title (if this is a fix up of a previous commit, it should be squashed)"
|
||||
fi
|
||||
|
||||
if [[ $line_number -eq 1 ]] && [[ "$line" =~ \.$ ]]; then
|
||||
error "Commit title ends in a period"
|
||||
fi
|
||||
|
||||
if [[ $line_length -gt 72 ]]; then
|
||||
error "Commit message lines are too long (maximum allowed is 72 characters)"
|
||||
fi
|
||||
|
|
Loading…
Reference in a new issue