beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Fix HTMLTable Element attributes

Browse source 
`Element::tag_name` return an uppercase version of the tag name. However
the `Web::HTML::TagNames` values are all lowercase.

This change fixes that using `Element::local_name`, which returns a
lowercase value.
This commit is contained in:
Adam Hodgen 2021-07-10 20:47:32 +01:00 committed by Andreas Kling
parent 99013ac3d5
commit 3e46e8fea8
Notes: sideshowbarker 2024-07-18 09:20:35 +09:00 
Author: https://github.com/ant1441
Commit: https://github.com/SerenityOS/serenity/commit/3e46e8fea82
Pull-request: https://github.com/SerenityOS/serenity/pull/8618
Issue: https://github.com/SerenityOS/serenity/issues/8599
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibWeb/HTML/HTMLTableElement.cpp
View file

@ -88,7 +88,7 @@ RefPtr<HTMLTableSectionElement> HTMLTableElement::t_head()
for (auto* child = first_child(); child; child = child->next_sibling()) { for (auto* child = first_child(); child; child = child->next_sibling()) {
if (is<HTMLTableSectionElement>(*child)) { if (is<HTMLTableSectionElement>(*child)) {
auto table_section_element = &verify_cast<HTMLTableSectionElement>(*child); auto table_section_element = &verify_cast<HTMLTableSectionElement>(*child);
if (table_section_element->tag_name() == TagNames::thead) if (table_section_element->local_name() == TagNames::thead)
return table_section_element; return table_section_element;
} }
} }
@ -101,7 +101,7 @@ DOM::ExceptionOr<void> HTMLTableElement::set_t_head(HTMLTableSectionElement* the
// FIXME: This is not always the case, but this function is currently written in a way that assumes non-null. // FIXME: This is not always the case, but this function is currently written in a way that assumes non-null.
VERIFY(thead); VERIFY(thead);
if (thead->tag_name() != TagNames::thead) if (thead->local_name() != TagNames::thead)
return DOM::HierarchyRequestError::create("Element is not thead"); return DOM::HierarchyRequestError::create("Element is not thead");
// FIXME: The spec requires deleting the current thead if thead is null // FIXME: The spec requires deleting the current thead if thead is null
@ -117,7 +117,7 @@ DOM::ExceptionOr<void> HTMLTableElement::set_t_head(HTMLTableSectionElement* the
continue; continue;
if (is<HTMLTableColElement>(*child)) { if (is<HTMLTableColElement>(*child)) {
auto table_col_element = &verify_cast<HTMLTableColElement>(*child); auto table_col_element = &verify_cast<HTMLTableColElement>(*child);
if (table_col_element->tag_name() == TagNames::colgroup) if (table_col_element->local_name() == TagNames::colgroup)
continue; continue;
} }
@ -148,7 +148,7 @@ NonnullRefPtr<HTMLTableSectionElement> HTMLTableElement::create_t_head()
continue; continue;
if (is<HTMLTableColElement>(*child)) { if (is<HTMLTableColElement>(*child)) {
auto table_col_element = &verify_cast<HTMLTableColElement>(*child); auto table_col_element = &verify_cast<HTMLTableColElement>(*child);
if (table_col_element->tag_name() == TagNames::colgroup) if (table_col_element->local_name() == TagNames::colgroup)
continue; continue;
} }
@ -175,7 +175,7 @@ RefPtr<HTMLTableSectionElement> HTMLTableElement::t_foot()
for (auto* child = first_child(); child; child = child->next_sibling()) { for (auto* child = first_child(); child; child = child->next_sibling()) {
if (is<HTMLTableSectionElement>(*child)) { if (is<HTMLTableSectionElement>(*child)) {
auto table_section_element = &verify_cast<HTMLTableSectionElement>(*child); auto table_section_element = &verify_cast<HTMLTableSectionElement>(*child);
if (table_section_element->tag_name() == TagNames::tfoot) if (table_section_element->local_name() == TagNames::tfoot)
return table_section_element; return table_section_element;
} }
} }
@ -188,7 +188,7 @@ DOM::ExceptionOr<void> HTMLTableElement::set_t_foot(HTMLTableSectionElement* tfo
// FIXME: This is not always the case, but this function is currently written in a way that assumes non-null. // FIXME: This is not always the case, but this function is currently written in a way that assumes non-null.
VERIFY(tfoot); VERIFY(tfoot);
if (tfoot->tag_name() != TagNames::tfoot) if (tfoot->local_name() != TagNames::tfoot)
return DOM::HierarchyRequestError::create("Element is not tfoot"); return DOM::HierarchyRequestError::create("Element is not tfoot");
// FIXME: The spec requires deleting the current tfoot if tfoot is null // FIXME: The spec requires deleting the current tfoot if tfoot is null
@ -223,7 +223,7 @@ void HTMLTableElement::delete_t_foot()
NonnullRefPtr<DOM::HTMLCollection> HTMLTableElement::t_bodies() NonnullRefPtr<DOM::HTMLCollection> HTMLTableElement::t_bodies()
{ {
return DOM::HTMLCollection::create(*this, [](DOM::Element const& element) { return DOM::HTMLCollection::create(*this, [](DOM::Element const& element) {
return element.tag_name() == TagNames::tbody; return element.local_name() == TagNames::tbody;
}); });
} }
@ -238,7 +238,7 @@ NonnullRefPtr<HTMLTableSectionElement> HTMLTableElement::create_t_body()
continue; continue;
if (is<HTMLTableSectionElement>(*child)) { if (is<HTMLTableSectionElement>(*child)) {
auto table_section_element = &verify_cast<HTMLTableSectionElement>(*child); auto table_section_element = &verify_cast<HTMLTableSectionElement>(*child);
if (table_section_element->tag_name() == TagNames::tbody) { if (table_section_element->local_name() == TagNames::tbody) {
// We have found an element which is a <tbody> we'll insert after this // We have found an element which is a <tbody> we'll insert after this
child_to_append_after = child->next_sibling(); child_to_append_after = child->next_sibling();
break; break;
@ -270,7 +270,7 @@ NonnullRefPtr<DOM::HTMLCollection> HTMLTableElement::rows()
if (element.parent_element() == table_node) if (element.parent_element() == table_node)
return true; return true;
if (element.parent_element() && (element.parent_element()->tag_name() == TagNames::thead || element.parent_element()->tag_name() == TagNames::tbody || element.parent_element()->tag_name() == TagNames::tfoot) if (element.parent_element() && (element.parent_element()->local_name() == TagNames::thead || element.parent_element()->local_name() == TagNames::tbody || element.parent_element()->local_name() == TagNames::tfoot)
&& element.parent()->parent() == table_node) { && element.parent()->parent() == table_node) {
return true; return true;
} }