beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: No longer return undefined on null table entry in Wasm API

Browse source 
Return `null` instead, as per the specification.
This commit is contained in:
Diego Frias 2024-07-30 10:24:25 -07:00 committed by Ali Mohammad Pur
parent 93216a875e
commit 3c5e3eef10
Notes: github-actions[bot] 2024-07-30 21:44:36 +00:00 
Author: https://github.com/dzfrias
Commit: https://github.com/LadybirdBrowser/ladybird/commit/3c5e3eef10a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/909
Reviewed-by: https://github.com/alimpfard
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/WebAssembly/Table.cpp
View file

@ -106,8 +106,6 @@ WebIDL::ExceptionOr<JS::Value> Table::get(u32 index) const
return vm.throw_completion<JS::RangeError>("Table element index out of range"sv); return vm.throw_completion<JS::RangeError>("Table element index out of range"sv);
auto& ref = table->elements()[index]; auto& ref = table->elements()[index];
if (!ref.ref().has<Wasm::Reference::Null>())
return JS::js_undefined();
Wasm::Value wasm_value { ref }; Wasm::Value wasm_value { ref };
return Detail::to_js_value(vm, wasm_value); return Detail::to_js_value(vm, wasm_value);

5
Userland/Libraries/LibWeb/WebAssembly/WebAssembly.cpp
View file

@ -450,7 +450,10 @@ JS::Value to_js_value(JS::VM& vm, Wasm::Value& wasm_value)
case Wasm::ValueType::F32: case Wasm::ValueType::F32:
return JS::Value(static_cast<double>(wasm_value.to<float>().value())); return JS::Value(static_cast<double>(wasm_value.to<float>().value()));
case Wasm::ValueType::FunctionReference: { case Wasm::ValueType::FunctionReference: {
auto address = wasm_value.to<Wasm::Reference::Func>().value().address; auto ref_ = *wasm_value.to<Wasm::Reference>();
if (ref_.ref().has<Wasm::Reference::Null>())
return JS::js_null();
auto address = ref_.ref().get<Wasm::Reference::Func>().address;
auto& cache = get_cache(realm); auto& cache = get_cache(realm);
auto* function = cache.abstract_machine().store().get(address); auto* function = cache.abstract_machine().store().get(address);
auto name = function->visit( auto name = function->visit(