beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Fix indexed access of TypedArray with byte offset

Browse source 
By doing the offset calculation in {get,put}_by_index() we would
delegate these operations to Object for any index >= (array length -
byte offset). By doing the offset calculation in data() instead, we can
just use the unaltered property index for indexing the returned Span.
In other words: data()[0] now returns the same value as indexing the
TypedArray at index 0 in JS.

This also fixes a bug in the js REPL which would not consider the byte
offset and subsequently access the underlying ArrayBuffer data with a
wrong index.
This commit is contained in:
Linus Groh 2021-05-21 19:29:05 +01:00
parent 9003dd907e
commit 3a4cbbf01c
Notes: sideshowbarker 2024-07-18 17:36:56 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/3a4cbbf01c6
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/TypedArray.h
View file

@ -51,7 +51,6 @@ class TypedArray : public TypedArrayBase {
public:
virtual bool put_by_index(u32 property_index, Value value) override
{
property_index += m_byte_offset / sizeof(T);
if (property_index >= m_array_length)
return Base::put_by_index(property_index, value);
@ -73,7 +72,6 @@ public:
virtual Value get_by_index(u32 property_index) const override
{
property_index += m_byte_offset / sizeof(T);
if (property_index >= m_array_length)
return Base::get_by_index(property_index);
@ -98,11 +96,11 @@ public:
Span<const T> data() const
{
return { reinterpret_cast<const T*>(m_viewed_array_buffer->buffer().data()), m_array_length };
return { reinterpret_cast<const T*>(m_viewed_array_buffer->buffer().data() + m_byte_offset), m_array_length };
}
Span<T> data()
{
return { reinterpret_cast<T*>(m_viewed_array_buffer->buffer().data()), m_array_length };
return { reinterpret_cast<T*>(m_viewed_array_buffer->buffer().data() + m_byte_offset), m_array_length };
}
virtual size_t element_size() const override { return sizeof(T); };