beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Add naive implementations of AK::timing_safe_compare

Browse source 
For security critical code we need to have some way of performing
constant time buffer comparisons.
This commit is contained in:
Brian Gianforcaro 2022-03-12 21:42:01 -08:00 committed by Brian Gianforcaro
parent 02b2f2787a
commit 390666b9fa
Notes: sideshowbarker 2024-07-17 17:28:00 +09:00 
Author: https://github.com/bgianfo
Commit: https://github.com/SerenityOS/serenity/commit/390666b9fa
Pull-request: https://github.com/SerenityOS/serenity/pull/13021
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/awesomekling ✅
2 changed files with 37 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
AK/Memory.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2021-2022, Brian Gianforcaro <bgianf@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -42,6 +43,7 @@ ALWAYS_INLINE void fast_u32_fill(u32* dest, u32 value, size_t count)
}
namespace AK {
inline void secure_zero(void* ptr, size_t size)
{
__builtin_memset(ptr, 0, size);
@ -50,6 +52,29 @@ inline void secure_zero(void* ptr, size_t size)
asm volatile("" ::
: "memory");
}
// Naive implementation of a constant time buffer comparison function.
// The goal being to not use any conditional branching so calls are
// guarded against potential timing attacks.
//
// See OpenBSD's timingsafe_memcmp for more advanced implementations.
inline bool timing_safe_compare(const void* b1, const void* b2, size_t len)
{
auto* c1 = static_cast<const char*>(b1);
auto* c2 = static_cast<const char*>(b2);
u8 res = 0;
for (size_t i = 0; i < len; i++) {
res |= c1[i] ^ c2[i];
}
// FIXME: !res can potentially inject branches depending
// on which toolchain is being used for compilation. Ideally
// we would use a more advanced algorithm.
return !res;
}
}
using AK::secure_zero;
using AK::timing_safe_compare;

13
Tests/AK/TestMemory.cpp
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, the SerenityOS developers.
* Copyright (c) 2020-2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -7,6 +7,8 @@
#include <LibTest/TestCase.h>
#include <AK/MemMem.h>
#include <AK/Memory.h>
#include <AK/String.h>
TEST_CASE(bitap)
{
@ -66,3 +68,12 @@ TEST_CASE(kmp_two_chunks)
EXPECT_EQ(result_2.value_or(9), 4u);
EXPECT(!result_3.has_value());
}
TEST_CASE(timing_safe_compare)
{
String data_set = "abcdefghijklmnopqrstuvwxyz123456789";
EXPECT_EQ(true, AK::timing_safe_compare(data_set.characters(), data_set.characters(), data_set.length()));
String reversed = data_set.reverse();
EXPECT_EQ(false, AK::timing_safe_compare(data_set.characters(), reversed.characters(), reversed.length()));
}