beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 17:40:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibJS/JIT: Compile the DeleteByIdWithThis instruction

Browse source
This commit is contained in:
Simon Wanner 2023-10-29 22:05:09 +01:00 committed by Andreas Kling
parent b53277110e
commit 38d5d7979b
Notes: sideshowbarker 2024-07-17 18:23:22 +09:00 
Author: https://github.com/skyrising
Commit: https://github.com/SerenityOS/serenity/commit/38d5d7979b
Pull-request: https://github.com/SerenityOS/serenity/pull/21682
3 changed files with 22 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/Bytecode/Op.h
View file

@ -747,6 +747,9 @@ public:
ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const;
DeprecatedString to_deprecated_string_impl(Bytecode::Executable const&) const;
Register this_value() const { return m_this_value; }
IdentifierTableIndex property() const { return m_property; }
private:
Register m_this_value;
IdentifierTableIndex m_property;

17
Userland/Libraries/LibJS/JIT/Compiler.cpp
View file

@ -1469,6 +1469,23 @@ void Compiler::compile_get_by_value_with_this(Bytecode::Op::GetByValueWithThis c
check_exception();
}
static Value cxx_delete_by_id_with_this(VM& vm, Value base_value, DeprecatedFlyString const& identifier, Value this_value)
{
auto reference = Reference { base_value, identifier, this_value, vm.in_strict_mode() };
return Value(TRY_OR_SET_EXCEPTION(reference.delete_(vm)));
}
void Compiler::compile_delete_by_id_with_this(Bytecode::Op::DeleteByIdWithThis const& op)
{
load_vm_register(ARG1, Bytecode::Register::accumulator());
m_assembler.mov(
Assembler::Operand::Register(ARG2),
Assembler::Operand::Imm(bit_cast<u64>(&m_bytecode_executable.get_identifier(op.property()))));
load_vm_register(ARG3, op.this_value());
native_call((void*)cxx_delete_by_id_with_this);
store_vm_register(Bytecode::Register::accumulator(), RET);
}
void Compiler::jump_to_exit()
{
m_assembler.jump(m_exit_label);

3
Userland/Libraries/LibJS/JIT/Compiler.h
View file

@ -123,7 +123,8 @@ private:
O(GetPrivateById, get_private_by_id) \
O(ResolveSuperBase, resolve_super_base) \
O(GetByIdWithThis, get_by_id_with_this) \
O(GetByValueWithThis, get_by_value_with_this)
O(GetByValueWithThis, get_by_value_with_this) \
O(DeleteByIdWithThis, delete_by_id_with_this)
# define DECLARE_COMPILE_OP(OpTitleCase, op_snake_case) \
void compile_##op_snake_case(Bytecode::Op::OpTitleCase const&);