beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

TerminalSettings: Spruce up the "Terminal" tab a bit

Browse source 
- Use sentence style capitalization for CheckBox and GroupBox titles
- Remove excessive explanation of bell mode.
- Put a "lines" label after the scrollback history length input instead
  of saying "(Lines)" in the GroupBox title.
- Tweak bell mode titles to make them self explanatory.
- Tweak language for exit confirmation.
This commit is contained in:
Andreas Kling 2023-03-03 10:41:47 +01:00
parent 880504e51d
commit 3823f77d20
Notes: sideshowbarker 2024-07-17 18:23:22 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/3823f77d20
1 changed files with 35 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

63
Userland/Applications/TerminalSettings/TerminalSettingsMain.gml
View file

@ -6,16 +6,43 @@
}
@GUI::GroupBox {
title: "Bell Mode"
title: "Scrollback"
preferred_height: "fit"
layout: @GUI::VerticalBoxLayout {
margins: [8]
spacing: 8
}
@GUI::Label {
text: "This setting controls the terminal's indication of an ANSI 0x07 bell (\\a)."
text_alignment: "TopLeft"
@GUI::Widget {
preferred_height: "shrink"
layout: @GUI::HorizontalBoxLayout {}
@GUI::SpinBox {
name: "history_size_spinbox"
min: 0
max: 40960
orientation: "Horizontal"
preferred_width: 100
}
@GUI::Label {
text: "lines"
autosize: true
}
}
@GUI::CheckBox {
name: "terminal_show_scrollbar"
text: "Show terminal scrollbar"
}
}
@GUI::GroupBox {
title: "Bell mode"
preferred_height: "fit"
layout: @GUI::VerticalBoxLayout {
margins: [8]
spacing: 8
}
@GUI::Widget {
@ -26,12 +53,12 @@
@GUI::RadioButton {
name: "beep_bell_radio"
text: "System beep"
text: "Audible bell"
}
@GUI::RadioButton {
name: "visual_bell_radio"
text: "Visual bell"
text: "Visible bell"
}
@GUI::RadioButton {
@ -42,27 +69,7 @@
}
@GUI::GroupBox {
title: "Scrollback Size (Lines)"
preferred_height: "fit"
layout: @GUI::VerticalBoxLayout {
margins: [8]
}
@GUI::CheckBox {
name: "terminal_show_scrollbar"
text: "Show scrollbar"
}
@GUI::SpinBox {
name: "history_size_spinbox"
min: 0
max: 40960
orientation: "Horizontal"
}
}
@GUI::GroupBox {
title: "Exit Behaviour"
title: "Exit behavior"
preferred_height: "fit"
layout: @GUI::VerticalBoxLayout {
margins: [8]
@ -70,7 +77,7 @@
@GUI::CheckBox {
name: "terminal_confirm_close"
text: "Ask before closing if processes are running in the terminal"
text: "Confirm exit when process is active"
}
}
}