From 3713164fa30932e5625b21f3867fe8c2d926dbc0 Mon Sep 17 00:00:00 2001
From: Linus Groh <mail@linusgroh.de>
Date: Fri, 16 Jul 2021 00:12:03 +0100
Subject: [PATCH] LibJS: Implement Temporal.Duration.prototype.sign

---
 .../Runtime/Temporal/DurationPrototype.cpp      | 14 ++++++++++++++
 .../LibJS/Runtime/Temporal/DurationPrototype.h  |  1 +
 .../Duration/Duration.prototype.sign.js         | 17 +++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.sign.js

diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp
index 805e53b4a9b..0b894fbad93 100644
--- a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp
+++ b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp
@@ -35,6 +35,7 @@ void DurationPrototype::initialize(GlobalObject& global_object)
     define_native_accessor(vm.names.milliseconds, milliseconds_getter, {}, Attribute::Configurable);
     define_native_accessor(vm.names.microseconds, microseconds_getter, {}, Attribute::Configurable);
     define_native_accessor(vm.names.nanoseconds, nanoseconds_getter, {}, Attribute::Configurable);
+    define_native_accessor(vm.names.sign, sign_getter, {}, Attribute::Configurable);
 }
 
 static Duration* typed_this(GlobalObject& global_object)
@@ -180,4 +181,17 @@ JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::nanoseconds_getter)
     return Value(duration->nanoseconds());
 }
 
+// 7.3.13 get Temporal.Duration.prototype.sign, https://tc39.es/proposal-temporal/#sec-get-temporal.duration.prototype.sign
+JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::sign_getter)
+{
+    // 1. Let duration be the this value.
+    // 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]).
+    auto* duration = typed_this(global_object);
+    if (vm.exception())
+        return {};
+
+    // 3. Return ! DurationSign(duration.[[Years]], duration.[[Months]], duration.[[Weeks]], duration.[[Days]], duration.[[Hours]], duration.[[Minutes]], duration.[[Seconds]], duration.[[Milliseconds]], duration.[[Microseconds]], duration.[[Nanoseconds]]).
+    return Value(duration_sign(duration->years(), duration->months(), duration->weeks(), duration->days(), duration->hours(), duration->minutes(), duration->seconds(), duration->milliseconds(), duration->microseconds(), duration->nanoseconds()));
+}
+
 }
diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h
index 6494d75e9de..719fe8aac9a 100644
--- a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h
+++ b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h
@@ -29,6 +29,7 @@ private:
     JS_DECLARE_NATIVE_FUNCTION(milliseconds_getter);
     JS_DECLARE_NATIVE_FUNCTION(microseconds_getter);
     JS_DECLARE_NATIVE_FUNCTION(nanoseconds_getter);
+    JS_DECLARE_NATIVE_FUNCTION(sign_getter);
 };
 
 }
diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.sign.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.sign.js
new file mode 100644
index 00000000000..024666a728e
--- /dev/null
+++ b/Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.sign.js
@@ -0,0 +1,17 @@
+describe("correct behavior", () => {
+    test("basic functionality", () => {
+        const positiveDuration = new Temporal.Duration(123);
+        expect(positiveDuration.sign).toBe(1);
+
+        const negativeDuration = new Temporal.Duration(-123);
+        expect(negativeDuration.sign).toBe(-1);
+    });
+});
+
+test("errors", () => {
+    test("this value must be a Temporal.Duration object", () => {
+        expect(() => {
+            Reflect.get(Temporal.Duration.prototype, "sign", "foo");
+        }).toThrowWithMessage(TypeError, "Not a Temporal.Duration");
+    });
+});